Skip to content

Commit 00a3fc7

Browse files
committed
fix: make client secret argument optional
The client secret is not required in PKCE authentication mode. See dexidp/dex#2244 for more info
1 parent c0930a5 commit 00a3fc7

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

internal/auth/authenticator_oidc.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,12 +271,15 @@ func extractOAuth2Args(msg *message.Message, readClientInfoFromMessages bool) (O
271271
}
272272
}
273273

274-
if clientid == nil || clientsecret == nil || redirecturl == nil {
274+
if clientid == nil || redirecturl == nil {
275275
temp := ""
276276
clientid = &temp
277-
clientsecret = &temp
278277
redirecturl = &temp
279278
}
279+
if clientsecret == nil {
280+
temp := ""
281+
clientsecret = &temp
282+
}
280283
return OAuthArgs{ssl: ssl, host: host, pathq: pathq,
281284
cookie: cookie, clientid: *clientid,
282285
clientsecret: *clientsecret, redirecturl: *redirecturl},

0 commit comments

Comments
 (0)