Fix: PDFKnowledgeSource instantiation error (Issue #2619) #2620
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…owledgeSource instantiation error Co-Authored-By: Joe Moura <joao@crewai.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Joe Moura <joao@crewai.com>
Co-Authored-By: Joe Moura <joao@crewai.com>
Co-Authored-By: Joe Moura <joao@crewai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PDFKnowledgeSource instantiation error (Issue #2619)
Problem
Users were unable to instantiate
PDFKnowledgeSourcewith the error: "Can't instantiate abstract class BaseKnowledgeSource without an implementation for abstract methods 'add', 'validate_content'".Solution
The issue was that
BaseFileKnowledgeSource(whichPDFKnowledgeSourceinherits from) didn't implement the requiredadd()method fromBaseKnowledgeSource.This PR adds the missing
add()implementation toBaseFileKnowledgeSource, which completes the inheritance chain and allowsPDFKnowledgeSourceand other file-based knowledge sources to be instantiated without errors.Tests
PDFKnowledgeSourceinstantiationFixes #2619
Link to Devin run: https://app.devin.ai/sessions/35a90afe7c6c4299b219c2dc01331798
Requested by: Joe Moura (joao@crewai.com)