Skip to content

Commit 90d221c

Browse files
anjannathpraveenkumar
authored andcommitted
remove tip in login page about crc credentials
this removes the patching we were doing to the default login page informing users to run the command `crc console --credentials` to get the login password this is done because with 4.19 ocp the default ocp branding html page is minified so the patch cannot be applied as is, we need to first unminimy it using another tool called 'tidy' since going forward we'll have a self sufficient bundle which can be run without the `crc` cli having the command on the login page is not very useful as users might not have the 'crc' cli
1 parent de98f96 commit 90d221c

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

oauth_cr.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,3 @@ spec:
1313
htpasswd:
1414
fileData:
1515
name: htpass-secret
16-
templates:
17-
login:
18-
name: login-template

snc.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -212,12 +212,6 @@ retry ${OC} patch config.imageregistry.operator.openshift.io/cluster --patch '{"
212212
# Set default route for registry CRD from false to true.
213213
retry ${OC} patch config.imageregistry.operator.openshift.io/cluster --patch '{"spec":{"defaultRoute":true}}' --type=merge
214214

215-
# Add a tip in the login page
216-
secret_template=$(retry ${OC} get secrets -n openshift-authentication v4-0-config-system-ocp-branding-template -o json)
217-
${JQ} -r '.data["login.html"]' <(echo "${secret_template}") | base64 -d > login.html
218-
${PATCH} login.html < login.html.patch
219-
retry ${OC} create secret generic login-template --from-file=login.html -n openshift-config
220-
221215
# Generate the htpasswd file to have admin and developer user
222216
generate_htpasswd_file ${INSTALL_DIR} ${HTPASSWD_FILE}
223217

0 commit comments

Comments
 (0)