Skip to content

Commit 78f9b5c

Browse files
committed
Remove initramfs/vmlinuz references for mac bundles
After crc-org/crc#4309 we don't need to use those references for running the bundle on macOS so better to remove this unused code/reference. fixes: #992
1 parent add798e commit 78f9b5c

4 files changed

+5
-46
lines changed

crc-bundle-info.json.sample

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
# - 1.2: addition of 'storage.fileList'
99
# - 1.3: remove of 'clusterInfo.kubeadminPasswordFile'
1010
# - 1.4: addition of 'arch'
11-
"version": "1.4",
11+
# - 1.5: remove of 'node[0].kernelCmdLine', 'node[0].initramfs', 'node[0].kernel'
12+
"version": "1.5",
1213
# Type of this bundle content
1314
# Currently the only valid type is 'snc' (which stands for 'single-node-cluster')
1415
"type": "snc",
@@ -56,12 +57,6 @@
5657
"diskImage": "crc.qcow2"
5758
# Internal IP for which etcd certs are valid
5859
"internalIP": "192.168.126.11"
59-
# kernel command line of the node
60-
"kernelCmdLine": "BOOT_IMAGE=/ostree/rhcos-bf3b38268ddb2a2070dc587b361ce45c46a6f9e3606bbd3b5e15b2e6d3d47e5d/vmlinuz-4.18.0-80.1.2.el8_0.x86_64 console=tty0 console=ttyS0,115200n8 rootflags=defaults,prjquota rw root=UUID=a8fbdcb1-63ea-421e-8f6f-dac9cbbcc822 ostree=/ostree/boot.0/rhcos/bf3b38268ddb2a2070dc587b361ce45c46a6f9e3606bbd3b5e15b2e6d3d47e5d/0 coreos.oem.id=qemu ignition.platform.id=qemu"
61-
# initramfs file of the node
62-
"initramfs": "initramfs-4.18.0-80.1.2.el8_0.x86_64.img"
63-
# kernel file of the node
64-
"kernel": "vmlinuz-4.18.0-80.1.2.el8_0.x86_64"
6560
}
6661
],
6762
"storage": {

createdisk-library.sh

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -257,27 +257,15 @@ function generate_macos_bundle {
257257
local bundleType=$1
258258
local srcDir=$2
259259
local destDir=$3
260-
local tmpDir=$4
261-
local kernel_release=$5
262-
local kernel_cmd_line=$6
260+
263261

264262
mkdir -p "$destDir"
265263
cp $srcDir/kubeconfig $destDir/
266264
cp $srcDir/id_ecdsa_crc $destDir/
267-
cp $tmpDir/vmlinuz-${kernel_release} $destDir/
268-
cp $tmpDir/initramfs-${kernel_release}.img $destDir/
269265

270266
# Copy oc client
271267
cp openshift-clients/mac/oc $destDir/
272268

273-
# aarch64 only supports uncompressed kernels, see
274-
# https://github.com/code-ready/vfkit/commit/4aaa4fbdc76f9fc0ccec2b9fda25c5235664e7d6
275-
# for more details
276-
if [ "${ARCH}" == "aarch64" ]; then
277-
mv $destDir/vmlinuz-${kernel_release} $destDir/vmlinuz-${kernel_release}.gz
278-
gunzip $destDir/vmlinuz-${kernel_release}.gz
279-
fi
280-
281269
cp podman-remote/mac/podman $destDir/
282270

283271
ocSize=$(du -b $destDir/oc | awk '{print $1}')
@@ -289,9 +277,6 @@ function generate_macos_bundle {
289277
# Update the bundle metadata info
290278
cat $srcDir/crc-bundle-info.json \
291279
| ${JQ} ".name = \"${destDir}\"" \
292-
| ${JQ} ".nodes[0].kernel = \"vmlinuz-${kernel_release}\"" \
293-
| ${JQ} ".nodes[0].initramfs = \"initramfs-${kernel_release}.img\"" \
294-
| ${JQ} ".nodes[0].kernelCmdLine = \"${kernel_cmd_line}\"" \
295280
| ${JQ} ".storage.fileList[0].name = \"oc\"" \
296281
| ${JQ} '.storage.fileList[0].type = "oc-executable"' \
297282
| ${JQ} ".storage.fileList[0].size = \"${ocSize}\"" \

createdisk.sh

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -155,22 +155,6 @@ fi
155155

156156
podman_version=$(${SSH} core@${VM_IP} -- 'rpm -q --qf %{version} podman')
157157

158-
# Get the rhcos ostree Hash ID
159-
ostree_hash=$(${SSH} core@${VM_IP} -- "cat /proc/cmdline | grep -oP \"(?<=${BASE_OS}-).*(?=/vmlinuz)\"")
160-
161-
# Get the rhcos kernel release
162-
kernel_release=$(${SSH} core@${VM_IP} -- 'uname -r')
163-
164-
# Get the kernel command line arguments
165-
kernel_cmd_line=$(${SSH} core@${VM_IP} -- 'cat /proc/cmdline')
166-
167-
# Get the vmlinux/initramfs to /tmp/kernel and change permission for initramfs
168-
${SSH} core@${VM_IP} -- "mkdir /tmp/kernel && sudo cp -r /boot/ostree/${BASE_OS}-${ostree_hash}/*${kernel_release}* /tmp/kernel && sudo chmod 644 /tmp/kernel/initramfs*"
169-
170-
# SCP the vmlinuz/initramfs from VM to Host in provided folder.
171-
${SCP} -r core@${VM_IP}:/tmp/kernel/* $INSTALL_DIR
172-
${SSH} core@${VM_IP} -- "sudo rm -fr /tmp/kernel"
173-
174158
# Shutdown the VM
175159
shutdown_vm ${VM_NAME}
176160

@@ -207,9 +191,5 @@ fi
207191
if [ "${SNC_GENERATE_MACOS_BUNDLE}" != "0" ]; then
208192
vfkitDestDir="${destDirPrefix}_vfkit_${destDirSuffix}"
209193
rm -fr ${vfkitDestDir} ${vfkitDestDir}.crcbundle
210-
generate_vfkit_bundle "$libvirtDestDir" "$vfkitDestDir" "$INSTALL_DIR" "$kernel_release" "$kernel_cmd_line"
211-
212-
# Cleanup up vmlinux/initramfs files
213-
rm -fr "$INSTALL_DIR/vmlinuz*" "$INSTALL_DIR/initramfs*"
194+
generate_vfkit_bundle "$libvirtDestDir" "$vfkitDestDir"
214195
fi
215-

test-metadata-generation.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ mkdir -p "$srcDir"
2727
mkdir -p "$srcDir/auth"
2828
touch "$srcDir"/auth/kubeconfig
2929
touch id_ecdsa_crc
30-
touch "$srcDir"/vmlinuz-0.0.0
31-
touch "$srcDir"/initramfs-0.0.0.img
30+
3231

3332
echo {} | ${JQ} '.version = "1.2"' \
3433
| ${JQ} '.type = "snc"' \

0 commit comments

Comments
 (0)