Skip to content

Commit 4216409

Browse files
author
binhnd
committed
Merge branch 'owner/master'
# Conflicts: # ios/RNSplashScreen.h
2 parents 1ccb99a + e39fdd5 commit 4216409

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ You can create splash screens in the following folders:
183183
* `drawable-xxhdpi`
184184
* `drawable-xxxhdpi`
185185

186-
Add a color called `primary_dark` in `app/src/main/res/values/color.xml`
186+
Add a color called `primary_dark` in `app/src/main/res/values/colors.xml`
187187

188188
```
189189
<?xml version="1.0" encoding="utf-8"?>

ios/SplashScreen.h renamed to ios/RNSplashScreen.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#import <React/RCTBridgeModule.h>
1010
#import <UIKit/UIKit.h>
1111

12-
@interface SplashScreen : NSObject<RCTBridgeModule>
12+
@interface RNSplashScreen : NSObject<RCTBridgeModule>
1313
+ (void)showSplash:(NSString*)splashScreen inRootView:(UIView*)rootView;
1414
+ (void)show;
1515
+ (void)hide;

ios/SplashScreen.m renamed to ios/RNSplashScreen.m

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@
77
* Email:crazycodeboy@gmail.com
88
*/
99

10-
#import "SplashScreen.h"
10+
#import "RNSplashScreen.h"
1111
#import <React/RCTBridge.h>
1212

1313
static bool waiting = true;
1414
static bool addedJsLoadErrorObserver = false;
1515
static UIView* loadingView = nil;
1616

17-
@implementation SplashScreen
17+
@implementation RNSplashScreen
1818
- (dispatch_queue_t)methodQueue{
1919
return dispatch_get_main_queue();
2020
}
21-
RCT_EXPORT_MODULE()
21+
RCT_EXPORT_MODULE(SplashScreen)
2222

2323
+ (void)show {
2424
if (!addedJsLoadErrorObserver) {
@@ -59,11 +59,11 @@ + (void)hide {
5959
+ (void) jsLoadError:(NSNotification*)notification
6060
{
6161
// If there was an error loading javascript, hide the splash screen so it can be shown. Otherwise the splash screen will remain forever, which is a hassle to debug.
62-
[SplashScreen hide];
62+
[RNSplashScreen hide];
6363
}
6464

6565
RCT_EXPORT_METHOD(hide) {
66-
[SplashScreen hide];
66+
[RNSplashScreen hide];
6767
}
6868

6969
@end

ios/SplashScreen.xcodeproj/project.pbxproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
objects = {
88

99
/* Begin PBXBuildFile section */
10-
3D7682841D8E76D10014119E /* SplashScreen.m in Sources */ = {isa = PBXBuildFile; fileRef = 3D7682831D8E76D10014119E /* SplashScreen.m */; };
10+
3D7682841D8E76D10014119E /* RNSplashScreen.m in Sources */ = {isa = PBXBuildFile; fileRef = 3D7682831D8E76D10014119E /* RNSplashScreen.m */; };
1111
/* End PBXBuildFile section */
1212

1313
/* Begin PBXCopyFilesBuildPhase section */
@@ -24,8 +24,8 @@
2424

2525
/* Begin PBXFileReference section */
2626
3D7682761D8E76B80014119E /* libSplashScreen.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libSplashScreen.a; sourceTree = BUILT_PRODUCTS_DIR; };
27-
3D7682821D8E76D10014119E /* SplashScreen.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SplashScreen.h; sourceTree = "<group>"; };
28-
3D7682831D8E76D10014119E /* SplashScreen.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SplashScreen.m; sourceTree = "<group>"; };
27+
3D7682821D8E76D10014119E /* RNSplashScreen.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RNSplashScreen.h; sourceTree = "<group>"; };
28+
3D7682831D8E76D10014119E /* RNSplashScreen.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RNSplashScreen.m; sourceTree = "<group>"; };
2929
/* End PBXFileReference section */
3030

3131
/* Begin PBXFrameworksBuildPhase section */
@@ -42,8 +42,8 @@
4242
3D76826D1D8E76B80014119E = {
4343
isa = PBXGroup;
4444
children = (
45-
3D7682821D8E76D10014119E /* SplashScreen.h */,
46-
3D7682831D8E76D10014119E /* SplashScreen.m */,
45+
3D7682821D8E76D10014119E /* RNSplashScreen.h */,
46+
3D7682831D8E76D10014119E /* RNSplashScreen.m */,
4747
3D7682771D8E76B80014119E /* Products */,
4848
);
4949
sourceTree = "<group>";
@@ -113,7 +113,7 @@
113113
isa = PBXSourcesBuildPhase;
114114
buildActionMask = 2147483647;
115115
files = (
116-
3D7682841D8E76D10014119E /* SplashScreen.m in Sources */,
116+
3D7682841D8E76D10014119E /* RNSplashScreen.m in Sources */,
117117
);
118118
runOnlyForDeploymentPostprocessing = 0;
119119
};

0 commit comments

Comments
 (0)