Skip to content

Commit 7190d8c

Browse files
committed
Npgsql: Stop running tests on .NET framework version 5.x
The tests are flawed: They signal "green" status on CI, but actually no tests are compiled and executed.
1 parent e7b98e4 commit 7190d8c

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

.github/workflows/test-npgsql.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
fail-fast: false
4343
matrix:
4444
os: [ 'ubuntu-latest' ]
45-
dotnet-version: [ '5.0.x', '6.0.x', '7.0.x', '8.0.x' ]
45+
dotnet-version: [ '6.0.x', '7.0.x', '8.0.x' ]
4646
npgsql-version: [ '6.0.10', '7.0.6' ]
4747
cratedb-version: [ 'nightly' ]
4848

by-language/csharp-npgsql/README.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ need for a plugin.
2424
Please note that Npgsql 5 is not supported starting with CrateDB 4.8.4, you
2525
will need Npgsql 6 or newer.
2626

27-
.NET 5, 6, and 7 are supported, .NET 3.1 and 4.6 may still work.
27+
.NET 6, 7, and 8 are supported, .NET 3.1, 4.6, and 5.0 may still work.
2828

2929

3030
*****
@@ -37,34 +37,34 @@ To invoke a CrateDB instance for evaluation purposes, run::
3737

3838
Invoke example program::
3939

40-
dotnet run --framework=net5.0
40+
dotnet run --framework=net8.0
4141

4242
To connect to CrateDB Cloud, use a command like::
4343

44-
dotnet run --framework=net5.0 -- \
44+
dotnet run --framework=net8.0 -- \
4545
--host=clustername.aks1.westeurope.azure.cratedb.net --ssl-mode=Require \
4646
--username=foobar --password='X8F%Shn)TESTvF5ac7%eW4NM'
4747

4848
Explore all available connection options::
4949

50-
dotnet run --framework=net5.0 -- --help
50+
dotnet run --framework=net8.0 -- --help
5151

5252

5353
Tests
5454
=====
5555

5656
For running the test scenarios wrapped into a xUnit test suite, invoke::
5757

58-
dotnet test --framework=net5.0
58+
dotnet test --framework=net8.0
5959

6060
To generate a Cobertura code coverage report, run::
6161

62-
dotnet test --framework=net5.0 --collect:"XPlat Code Coverage"
62+
dotnet test --framework=net8.0 --collect:"XPlat Code Coverage"
6363

6464
For running the tests against a remote database, use, for example::
6565

6666
export CRATEDB_DSN='Host=clustername.aks1.westeurope.azure.cratedb.net;Port=5432;SSL Mode=Require;Username=foobar;Password=X8F%Shn)TESTvF5ac7%eW4NM;Database=testdrive'
67-
dotnet test --framework=net5.0
67+
dotnet test --framework=net8.0
6868

6969

7070
.. _C#: https://en.wikipedia.org/wiki/C_Sharp_(programming_language)

0 commit comments

Comments
 (0)