Refactor screen and instruction tests (#122)

craigthomas · web-flow · commit cd43b3109195 · 2025-02-20T23:26:58.000-05:00
* Move screen datatypes and add tests for instructions

* Add in unit tests for addressing modes
diff --git a/src/main/java/ca/craigthomas/yacoco3e/components/IOController.java b/src/main/java/ca/craigthomas/yacoco3e/components/IOController.java
@@ -5,6 +5,7 @@
 package ca.craigthomas.yacoco3e.components;
 
 import ca.craigthomas.yacoco3e.datatypes.*;
+import ca.craigthomas.yacoco3e.datatypes.screen.ScreenMode;
 
 import static ca.craigthomas.yacoco3e.datatypes.RegisterSet.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/components/Instruction.java b/src/main/java/ca/craigthomas/yacoco3e/components/Instruction.java
@@ -60,33 +60,30 @@ public int execute(IOController io) throws MalformedInstructionException {
             io.incrementPC();
         }
 
-        if (!isValidInstruction) {
-            call(io);
-            return 0;
-        }
-
-        switch (addressingMode) {
-            case IMMEDIATE:
-                getImmediate(io);
-                break;
-
-            case INDEXED:
-                getIndexed(io);
-                break;
-
-            case DIRECT:
-                getDirect(io);
-                break;
-
-            case EXTENDED:
-                getExtended(io);
-                break;
-
-            default:
-                addressRead = new UnsignedWord(0);
-                wordRead = new UnsignedWord(0);
-                byteRead = new UnsignedByte(0);
-                break;
+        if (isValidInstruction) {
+            switch (addressingMode) {
+                case IMMEDIATE:
+                    getImmediate(io);
+                    break;
+
+                case INDEXED:
+                    getIndexed(io);
+                    break;
+
+                case DIRECT:
+                    getDirect(io);
+                    break;
+
+                case EXTENDED:
+                    getExtended(io);
+                    break;
+
+                default:
+                    addressRead = new UnsignedWord(0);
+                    wordRead = new UnsignedWord(0);
+                    byteRead = new UnsignedByte(0);
+                    break;
+            }
         }
 
         return call(io);
diff --git a/src/main/java/ca/craigthomas/yacoco3e/components/Screen.java b/src/main/java/ca/craigthomas/yacoco3e/components/Screen.java
@@ -4,9 +4,8 @@
  */
 package ca.craigthomas.yacoco3e.components;
 
-import ca.craigthomas.yacoco3e.datatypes.*;
+import ca.craigthomas.yacoco3e.datatypes.screen.*;
 
-import java.awt.*;
 import java.awt.image.BufferedImage;
 
 public class Screen
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/MemoryResult.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/MemoryResult.java
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G1CScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G1CScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G1RScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G1RScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G2CScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G2CScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G2RScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G2RScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G3CScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G3CScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G3RScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G3RScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G6CScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G6CScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G6RScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/G6RScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG12ScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG12ScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG24ScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG24ScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG4ScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG4ScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG6ScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG6ScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG8ScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/SG8ScreenMode.java
@@ -2,7 +2,9 @@
  * Copyright (C) 2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
+
+import ca.craigthomas.yacoco3e.datatypes.UnsignedByte;
 
 import java.awt.*;
 
diff --git a/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/ScreenMode.java b/src/main/java/ca/craigthomas/yacoco3e/datatypes/screen/ScreenMode.java
@@ -2,7 +2,7 @@
  * Copyright (C) 2017-2018 Craig Thomas
  * This project uses an MIT style license - see LICENSE for details.
  */
-package ca.craigthomas.yacoco3e.datatypes;
+package ca.craigthomas.yacoco3e.datatypes.screen;
 
 import ca.craigthomas.yacoco3e.components.IOController;
 
diff --git a/src/test/java/ca/craigthomas/yacoco3e/components/ByteInstructionTest.java b/src/test/java/ca/craigthomas/yacoco3e/components/ByteInstructionTest.java
diff --git a/src/test/java/ca/craigthomas/yacoco3e/components/InstructionTest.java b/src/test/java/ca/craigthomas/yacoco3e/components/InstructionTest.java
diff --git a/src/test/java/ca/craigthomas/yacoco3e/components/NotImplementedInstructionTest.java b/src/test/java/ca/craigthomas/yacoco3e/components/NotImplementedInstructionTest.java
diff --git a/src/test/java/ca/craigthomas/yacoco3e/datatypes/MemoryResultTest.java b/src/test/java/ca/craigthomas/yacoco3e/datatypes/MemoryResultTest.java
