Skip to content

Commit 4bf138f

Browse files
committed
Add reflector comments to 4017
1 parent 256fa10 commit 4bf138f

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

xml/issue4017.xml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,27 @@ The following demo shows Barry Revzin's implementation from <paper num="P2210"/>
6161
Set priority to 3 after reflector poll.
6262
</p>
6363

64+
<note>2024-03; Reflector comments</note>
65+
<p>
66+
"For `split`, we need to adjust the definition of `end()` for the
67+
`common_range` case
68+
(which may require introducing a new constructor to the iterator);
69+
right now it would compare `ranges::end(base_)` against a value-initialized
70+
iterator, which is not in the domain of `==`.
71+
For `lazy_split`, we need to also change the non-forward overload."
72+
</p>
73+
<p>
74+
"What should splitting an empty range on an empty pattern produce?
75+
Right now the behavior is that splitting a range of N &gt; 0 elements
76+
with an empty pattern produces a range of N single-element ranges.
77+
I suppose you can argue that an empty pattern matches between adjacent elements
78+
but not at the start or end, so that an empty range, like a single-element range,
79+
contains 0 delimiters so should produce a range of one empty range.
80+
But it's also at least arguable that this should produce an empty range instead,
81+
so that we maintain the N element &lt;-&gt; N subrange
82+
and 1 element per subrange invariant.
83+
</p>
84+
6485
</discussion>
6586

6687
<resolution>

0 commit comments

Comments
 (0)