Add Github Actions file references for Swift Testing issues (#440)

Ensures that we get the valid file/line/col output when we have Swift
Testing test failures when using the github actions renderer, which
allows swift testing failures to render inline in the github PR diff UI

Author: erichoracek

Sources/XcbeautifyLib/Renderers/Microsoft/MicrosoftOutputRendering.swift

@@ -229,9 +229,35 @@ extension MicrosoftOutputRendering {
     }
 
     func formatSwiftTestingIssue(group: SwiftTestingIssueCaptureGroup) -> String {
-        let message = "Recorded an issue" + (group.issueDetails.map { " (\($0))" } ?? "")
+        var fileComponents: FileComponents?
+        var detailMessage = group.issueDetails?.trimmingCharacters(in: .whitespacesAndNewlines)
+
+        if let issueDetails = detailMessage, !issueDetails.isEmpty {
+            let locationAndMessage = issueDetails.split(separator: ": ", maxSplits: 1, omittingEmptySubsequences: false)
+            if let locationPart = locationAndMessage.first {
+                let locationSegments = locationPart.split(separator: ":").map(String.init)
+                if let path = locationSegments.first, !path.isEmpty {
+                    let line = locationSegments.count > 1 ? Int(locationSegments[1]) : nil
+                    let column = locationSegments.count > 2 ? Int(locationSegments[2]) : nil
+                    fileComponents = FileComponents(path: path, line: line, column: column)
+                    if locationAndMessage.count > 1 {
+                        detailMessage = String(locationAndMessage[1]).trimmingCharacters(in: .whitespacesAndNewlines)
+                    } else {
+                        detailMessage = nil
+                    }
+                }
+            }
+        }
+
+        let message =
+            if let detailMessage, !detailMessage.isEmpty {
+                "Recorded an issue (\(detailMessage))"
+            } else {
+                "Recorded an issue"
+            }
         return makeOutputLog(
             annotation: .error,
+            fileComponents: fileComponents,
             message: message
         )
     }

Tests/XcbeautifyLibTests/RendererTests/AzureDevOpsPipelinesRendererTests.swift

@@ -758,7 +758,7 @@ final class AzureDevOpsPipelinesRendererTests: XCTestCase {
     func testSwiftTestingIssue() {
         let input = #"􀢄  Test "myTest" recorded an issue at PlanTests.swift:43:5: Expectation failed"#
         let formatted = logFormatted(input)
-        let expectedOutput = "##vso[task.logissue type=error]Recorded an issue (PlanTests.swift:43:5: Expectation failed)"
+        let expectedOutput = "##vso[task.logissue type=error;sourcepath=PlanTests.swift;linenumber=43;columnnumber=5]Recorded an issue (Expectation failed)"
         XCTAssertEqual(formatted, expectedOutput)
     }
 
@@ -772,7 +772,14 @@ final class AzureDevOpsPipelinesRendererTests: XCTestCase {
     func testSwiftTestingIssueDetails() {
         let input = #"􀢄  Test "myTest" recorded an issue at PlanTests.swift:43:5: Expectation failed"#
         let formatted = logFormatted(input)
-        let expectedOutput = "##vso[task.logissue type=error]Recorded an issue (PlanTests.swift:43:5: Expectation failed)"
+        let expectedOutput = "##vso[task.logissue type=error;sourcepath=PlanTests.swift;linenumber=43;columnnumber=5]Recorded an issue (Expectation failed)"
+        XCTAssertEqual(formatted, expectedOutput)
+    }
+
+    func testSwiftTestingIssueWithoutDetailsProvidesFileOnlyAnnotation() {
+        let input = #"􀢄  Test "myTest" recorded an issue at PlanTests.swift:43:5"#
+        let formatted = logFormatted(input)
+        let expectedOutput = "##vso[task.logissue type=error;sourcepath=PlanTests.swift;linenumber=43;columnnumber=5]Recorded an issue"
         XCTAssertEqual(formatted, expectedOutput)
     }
 

Tests/XcbeautifyLibTests/RendererTests/GitHubActionsRendererTests.swift

@@ -755,7 +755,7 @@ final class GitHubActionsRendererTests: XCTestCase {
     func testSwiftTestingIssue() {
         let input = #"􀢄  Test "myTest" recorded an issue at PlanTests.swift:43:5: Expectation failed"#
         let formatted = logFormatted(input)
-        let expectedOutput = "::error ::Recorded an issue (PlanTests.swift:43:5: Expectation failed)"
+        let expectedOutput = "::error file=PlanTests.swift,line=43,col=5::Recorded an issue (Expectation failed)"
         XCTAssertEqual(formatted, expectedOutput)
     }
 
@@ -769,7 +769,14 @@ final class GitHubActionsRendererTests: XCTestCase {
     func testSwiftTestingIssueDetails() {
         let input = #"􀢄  Test "myTest" recorded an issue at PlanTests.swift:43:5: Expectation failed"#
         let formatted = logFormatted(input)
-        let expectedOutput = "::error ::Recorded an issue (PlanTests.swift:43:5: Expectation failed)"
+        let expectedOutput = "::error file=PlanTests.swift,line=43,col=5::Recorded an issue (Expectation failed)"
+        XCTAssertEqual(formatted, expectedOutput)
+    }
+
+    func testSwiftTestingIssueWithoutDetailsProvidesFileOnlyAnnotation() {
+        let input = #"􀢄  Test "myTest" recorded an issue at PlanTests.swift:43:5"#
+        let formatted = logFormatted(input)
+        let expectedOutput = "::error file=PlanTests.swift,line=43,col=5::Recorded an issue"
         XCTAssertEqual(formatted, expectedOutput)
     }