Skip to content

Commit 28015f8

Browse files
committed
ocl: code cleanup
1 parent aa01346 commit 28015f8

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

src/acc/opencl/acc_opencl_event.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,14 @@ int c_dbcsr_acc_event_synchronize(void* event) { /* waits on the host-side */
168168
# endif
169169
assert(NULL != event);
170170
clevent = *ACC_OPENCL_EVENT(event);
171-
if (NULL != clevent) result = clWaitForEvents(1, &clevent);
171+
if (NULL != clevent) {
172+
if (0 == (32 & c_dbcsr_acc_opencl_config.wa)) result = clWaitForEvents(1, &clevent);
173+
else {
174+
cl_command_queue queue = NULL;
175+
result = clGetEventInfo(clevent, CL_EVENT_COMMAND_QUEUE, sizeof(cl_command_queue), &queue, NULL);
176+
if (EXIT_SUCCESS == result) result = clFinish(queue);
177+
}
178+
}
172179
else if (3 <= c_dbcsr_acc_opencl_config.verbosity || 0 > c_dbcsr_acc_opencl_config.verbosity) {
173180
fprintf(stderr, "WARN ACC/OpenCL: c_dbcsr_acc_event_synchronize discovered an empty event.\n");
174181
}

src/acc/opencl/smm/opencl_libsmm.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1141,20 +1141,16 @@ int opencl_libsmm_acc_process(const int* host_param_stack, const int* dev_param_
11411141
(NULL == env_wg || '\0' == *env_wg) ? (0 != defaults ? default_wg : config->wg) : atoi(env_wg), -2, 2);
11421142
new_config.nz = LIBXSMM_CLMP(
11431143
(NULL == env_nz || '\0' == *env_nz) ? (0 != defaults ? /*default*/ 0 : config->nz) : atoi(env_nz), 0, 1);
1144-
new_config.al = LIBXSMM_CLMP(/* bug: AL=1 */
1145-
(NULL == env_al || '\0' == *env_al)
1146-
? (0 == (64 & c_dbcsr_acc_opencl_config.wa) ? (0 != defaults ? /*default*/ 0 : config->al) : 0)
1147-
: atoi(env_al),
1148-
0, 1);
1144+
new_config.al = LIBXSMM_CLMP(/* bug with AL=1? */
1145+
(NULL == env_al || '\0' == *env_al) ? (0 != defaults ? /*default*/ 0 : config->al) : atoi(env_al), 0, 1);
11491146
new_config.tb = LIBXSMM_CLMP(
11501147
(NULL == env_tb || '\0' == *env_tb) ? (0 != defaults ? /*default*/ 0 : config->tb) : atoi(env_tb), 0, 1);
11511148
new_config.tc = LIBXSMM_CLMP(
11521149
(NULL == env_tc || '\0' == *env_tc) ? (0 != defaults ? /*default*/ 1 : config->tc) : atoi(env_tc), 0, 1);
11531150
new_config.ap = LIBXSMM_CLMP(
11541151
(NULL == env_ap || '\0' == *env_ap) ? (0 != defaults ? /*default*/ 0 : config->ap) : atoi(env_ap), 0, 1);
1155-
new_config.aa = LIBXSMM_CLMP(/* bug: AA=2 XF=1 */
1156-
(NULL == env_aa || '\0' == *env_aa) ? (0 != defaults ? default_aa : config->aa) : atoi(env_aa), 0,
1157-
(0 == (32 & c_dbcsr_acc_opencl_config.wa) || 0 == new_config.flags) ? 2 : 1);
1152+
new_config.aa = LIBXSMM_CLMP(/* bug with AA=2 XF=1? */
1153+
(NULL == env_aa || '\0' == *env_aa) ? (0 != defaults ? default_aa : config->aa) : atoi(env_aa), 0, 2);
11581154
new_config.ab = LIBXSMM_CLMP(
11591155
(NULL == env_ab || '\0' == *env_ab) ? (0 != defaults ? default_ab : config->ab) : atoi(env_ab), 0, 2);
11601156
new_config.ac = LIBXSMM_CLMP(

0 commit comments

Comments
 (0)