Fix for ignored exceptions (#1)

Use errors rather than exceptions, as runtime exceptions may be swallowed during initialization.

Author: fdeschodt

pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>com.coveo</groupId>
     <artifactId>spring-boot-parameter-store-integration</artifactId>
-    <version>1.0.0</version>
+    <version>1.0.1</version>
 
     <name>Spring Boot Parameter Store Integration</name>
     <description>An integration of Amazon Web Services' Systems Manager Parameter Store for Spring Boot's properties injection.</description>

src/main/java/com/coveo/configuration/parameterstore/ParameterStoreSource.java

@@ -3,8 +3,8 @@
 import com.amazonaws.services.simplesystemsmanagement.AWSSimpleSystemsManagement;
 import com.amazonaws.services.simplesystemsmanagement.model.GetParameterRequest;
 import com.amazonaws.services.simplesystemsmanagement.model.ParameterNotFoundException;
-import com.coveo.configuration.parameterstore.exception.ParameterStoreParameterNotFoundRuntimeException;
-import com.coveo.configuration.parameterstore.exception.ParameterStoreRuntimeException;
+import com.coveo.configuration.parameterstore.exception.ParameterStoreParameterNotFoundError;
+import com.coveo.configuration.parameterstore.exception.ParameterStoreError;
 
 public class ParameterStoreSource
 {
@@ -25,10 +25,10 @@ public Object getProperty(String propertyName)
                             .getValue();
         } catch (ParameterNotFoundException e) {
             if (haltBoot) {
-                throw new ParameterStoreParameterNotFoundRuntimeException(propertyName, e);
+                throw new ParameterStoreParameterNotFoundError(propertyName, e);
             }
         } catch (Exception e) {
-            throw new ParameterStoreRuntimeException(propertyName, e);
+            throw new ParameterStoreError(propertyName, e);
         }
         return null;
     }

src/main/java/com/coveo/configuration/parameterstore/exception/ParameterStoreRuntimeException.java renamed to src/main/java/com/coveo/configuration/parameterstore/exception/ParameterStoreError.java

@@ -1,10 +1,10 @@
 package com.coveo.configuration.parameterstore.exception;
 
-public class ParameterStoreRuntimeException extends RuntimeException
+public class ParameterStoreError extends Error
 {
     private static final long serialVersionUID = 1L;
 
-    public ParameterStoreRuntimeException(String propertyName, Exception e)
+    public ParameterStoreError(String propertyName, Exception e)
     {
         super(String.format("Accessing Parameter Store for parameter '%s' failed.", propertyName), e);
     }

src/main/java/com/coveo/configuration/parameterstore/exception/ParameterStoreParameterNotFoundRuntimeException.java renamed to src/main/java/com/coveo/configuration/parameterstore/exception/ParameterStoreParameterNotFoundError.java

@@ -2,11 +2,11 @@
 
 import com.coveo.configuration.parameterstore.ParameterStorePropertySource;
 
-public class ParameterStoreParameterNotFoundRuntimeException extends RuntimeException
+public class ParameterStoreParameterNotFoundError extends Error
 {
     private static final long serialVersionUID = 1L;
 
-    public ParameterStoreParameterNotFoundRuntimeException(String propertyName, Exception e)
+    public ParameterStoreParameterNotFoundError(String propertyName, Exception e)
     {
         super(String.format("Properties prefixed with a '%s' are reserved for the AWS Parameter Store. "
                 + "The property '%s' was not found in it. "

src/test/java/com/coveo/configuration/parameterstore/ParameterStoreSourceTest.java

@@ -15,8 +15,8 @@
 import com.amazonaws.services.simplesystemsmanagement.model.GetParameterResult;
 import com.amazonaws.services.simplesystemsmanagement.model.Parameter;
 import com.amazonaws.services.simplesystemsmanagement.model.ParameterNotFoundException;
-import com.coveo.configuration.parameterstore.exception.ParameterStoreParameterNotFoundRuntimeException;
-import com.coveo.configuration.parameterstore.exception.ParameterStoreRuntimeException;
+import com.coveo.configuration.parameterstore.exception.ParameterStoreError;
+import com.coveo.configuration.parameterstore.exception.ParameterStoreParameterNotFoundError;
 
 @RunWith(MockitoJUnitRunner.class)
 public class ParameterStoreSourceTest
@@ -57,15 +57,15 @@ public void testGetPropertyWhenNotFoundReturnsNull()
         assertThat(value, is(nullValue()));
     }
 
-    @Test(expected = ParameterStoreRuntimeException.class)
+    @Test(expected = ParameterStoreError.class)
     public void shouldThrowOnUnexpectedExceptionAccessingParameterStore()
     {
         when(ssmClientMock.getParameter(getParameterRequest(VALID_PROPERTY_NAME))).thenThrow(new RuntimeException());
 
         parameterStoreSource.getProperty(VALID_PROPERTY_NAME);
     }
 
-    @Test(expected = ParameterStoreParameterNotFoundRuntimeException.class)
+    @Test(expected = ParameterStoreParameterNotFoundError.class)
     public void shouldThrowOnGetPropertyWhenNotFoundAndHaltBootIsTrue()
     {
         when(ssmClientMock.getParameter(getParameterRequest(INVALID_PROPERTY_NAME))).thenThrow(new ParameterNotFoundException(""));