Skip to content

Commit 0d4f930

Browse files
committed
Remove some inappropriate logging lines since redaction is not in play anymore (until further notice)
1 parent 2f7e678 commit 0d4f930

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/Couchbase.Lite.Shared/Log/SecureLogString.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,9 @@ internal sealed class SecureLogJsonString : SecureLogItem
125125

126126
#endregion
127127

128-
[NotNull]
129128
#region Properties
130-
129+
130+
[NotNull]
131131
private string String
132132
{
133133
get {

src/Couchbase.Lite.Shared/Sync/HTTPLogic.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -166,15 +166,12 @@ public void ReceivedResponse(HttpMessageParser parser)
166166

167167
if (_authorizationHeader == null && Credential != null) {
168168
_authorizationHeader = CreateAuthHeader(authResponse);
169-
var password = new SecureLogString(Credential.Password, LogMessageSensitivity.Insecure);
170-
Log.To.Sync.I(Tag, $"Auth challenge; credential = {Credential.UserName} / {password}");
169+
Log.To.Sync.I(Tag, $"Auth challenge received for {Credential.UserName}");
171170
ShouldRetry = true;
172171
break;
173172
}
174173

175-
var auth = new SecureLogString(_authorizationHeader, LogMessageSensitivity.Insecure);
176-
var wwwAuth = new SecureLogString(authResponse, LogMessageSensitivity.Insecure);
177-
Log.To.Sync.I(Tag, $"HTTP auth failed; sent Authorization {auth} ; got WWW-Authenticate {wwwAuth}");
174+
Log.To.Sync.I(Tag, "HTTP auth failed");
178175
Error = new CouchbaseNetworkException(httpStatus);
179176
break;
180177
default:

src/Couchbase.Lite.Shared/Sync/ReplicatorOptionsDictionary.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ internal ReplicatorOptionsDictionary([NotNull]Dictionary<string, object> raw) :
198198
foreach (var entry in split) {
199199
var pieces = entry?.Split('=');
200200
if (pieces?.Length != 2) {
201-
Log.To.Sync.W(Tag, "Garbage cookie value, ignoring: {0}", new SecureLogString(entry, LogMessageSensitivity.Insecure));
201+
Log.To.Sync.W(Tag, "Garbage cookie value, ignoring");
202202
continue;
203203
}
204204

0 commit comments

Comments
 (0)