Skip to content

Commit 0d9eef8

Browse files
authored
fix changelog conflictg (#277)
1 parent 2195145 commit 0d9eef8

File tree

3 files changed

+1
-14
lines changed

3 files changed

+1
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
6363
* (modules/core) [\#109](https://github.com/cosmos/ibc-go/pull/109) Remove connection and channel handshake CLI commands.
6464
* (modules) [\#107](https://github.com/cosmos/ibc-go/pull/107) Modify OnRecvPacket callback to return an acknowledgement which indicates if it is successful or not. Callback state changes are discarded for unsuccessful acknowledgements only.
6565
* (modules) [\#108](https://github.com/cosmos/ibc-go/pull/108) All message constructors take the signer as a string to prevent upstream bugs. The `String()` function for an SDK Acc Address relies on external context.
66+
* (transfer) [\#275](https://github.com/cosmos/ibc-go/pull/275) Remove 'ChanCloseInit' function from transfer keeper. ICS20 does not close channels.
6667

6768
### State Machine Breaking
6869

modules/apps/transfer/keeper/keeper.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@ import (
77
"github.com/cosmos/cosmos-sdk/codec"
88
"github.com/cosmos/cosmos-sdk/store/prefix"
99
sdk "github.com/cosmos/cosmos-sdk/types"
10-
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
1110
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
1211
capabilitykeeper "github.com/cosmos/cosmos-sdk/x/capability/keeper"
1312
capabilitytypes "github.com/cosmos/cosmos-sdk/x/capability/types"
1413
paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
1514
"github.com/cosmos/ibc-go/modules/apps/transfer/types"
16-
channeltypes "github.com/cosmos/ibc-go/modules/core/04-channel/types"
1715
host "github.com/cosmos/ibc-go/modules/core/24-host"
1816
)
1917

@@ -69,17 +67,6 @@ func (k Keeper) GetTransferAccount(ctx sdk.Context) authtypes.ModuleAccountI {
6967
return k.authKeeper.GetModuleAccount(ctx, types.ModuleName)
7068
}
7169

72-
// ChanCloseInit defines a wrapper function for the channel Keeper's function
73-
// in order to expose it to the ICS20 transfer handler.
74-
func (k Keeper) ChanCloseInit(ctx sdk.Context, portID, channelID string) error {
75-
capName := host.ChannelCapabilityPath(portID, channelID)
76-
chanCap, ok := k.scopedKeeper.GetCapability(ctx, capName)
77-
if !ok {
78-
return sdkerrors.Wrapf(channeltypes.ErrChannelCapabilityNotFound, "could not retrieve channel capability at: %s", capName)
79-
}
80-
return k.channelKeeper.ChanCloseInit(ctx, portID, channelID, chanCap)
81-
}
82-
8370
// IsBound checks if the transfer module is already bound to the desired port
8471
func (k Keeper) IsBound(ctx sdk.Context, portID string) bool {
8572
_, ok := k.scopedKeeper.GetCapability(ctx, host.PortPath(portID))

modules/apps/transfer/types/expected_keepers.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ type ChannelKeeper interface {
2929
GetChannel(ctx sdk.Context, srcPort, srcChan string) (channel channeltypes.Channel, found bool)
3030
GetNextSequenceSend(ctx sdk.Context, portID, channelID string) (uint64, bool)
3131
SendPacket(ctx sdk.Context, channelCap *capabilitytypes.Capability, packet ibcexported.PacketI) error
32-
ChanCloseInit(ctx sdk.Context, portID, channelID string, chanCap *capabilitytypes.Capability) error
3332
}
3433

3534
// ClientKeeper defines the expected IBC client keeper

0 commit comments

Comments
 (0)