some automatic rector fixes

Author: splitbrain

action/migration.php

@@ -413,7 +413,7 @@ protected function getFixedValues($row)
             }
         }
 
-        if (!empty($fixes)) {
+        if ($fixes !== []) {
             $fixes = array_map(static fn($set, $key) => "$key = '$set'", $fixes, array_keys($fixes));
         }
 

helper/config.php

@@ -20,7 +20,7 @@ class helper_plugin_struct_config extends Plugin
      */
     public function parseSort($val)
     {
-        if (substr($val, 0, 1) == '^') {
+        if (str_starts_with($val, '^')) {
             return [substr($val, 1), false];
         }
         return [$val, true];

meta/Assignments.php

@@ -291,12 +291,12 @@ protected function matchPagePattern($pattern, $page, $pns = null)
         }
 
         $ans = ':' . cleanID($pattern) . ':';
-        if (substr($pattern, -2) == '**') {
+        if (str_ends_with($pattern, '**')) {
             // upper namespaces match
-            if (strpos($pns, $ans) === 0) {
+            if (str_starts_with($pns, $ans)) {
                 return true;
             }
-        } elseif (substr($pattern, -1) == '*') {
+        } elseif (str_ends_with($pattern, '*')) {
             // namespaces match exact
             if ($ans == $pns) {
                 return true;

meta/Column.php

@@ -193,9 +193,9 @@ public static function allTypes($reload = false)
         $files = glob(DOKU_PLUGIN . 'struct/types/*.php');
         foreach ($files as $file) {
             $file = basename($file, '.php');
-            if (substr($file, 0, 8) == 'Abstract') continue;
-            if (substr($file, 0, 5) == 'Trait') continue;
-            if (substr($file, 0, 4) == 'Auto') continue;
+            if (str_starts_with($file, 'Abstract')) continue;
+            if (str_starts_with($file, 'Trait')) continue;
+            if (str_starts_with($file, 'Auto')) continue;
             $map[$file] = 'dokuwiki\\plugin\\struct\\types\\' . $file;
         }
 

meta/SearchConfig.php

@@ -95,9 +95,9 @@ protected function determineCacheFlag($filters)
         foreach ($filters as $filter) {
             if (is_array($filter)) $filter = $filter[2]; // this is the format we get fro the config parser
 
-            if (strpos($filter, '$USER$') !== false) {
+            if (str_contains($filter, '$USER$')) {
                 $flags |= self::$CACHE_USER;
-            } elseif (strpos($filter, '$TODAY$') !== false) {
+            } elseif (str_contains($filter, '$TODAY$')) {
                 $flags |= self::$CACHE_DATE;
             }
         }
@@ -145,7 +145,7 @@ protected function applyFilterVars($filter)
             $resolver = new PageResolver('');
 
             $start = $resolver->resolveId($ns . ':');
-            if($start === $INFO['id']) {
+            if ($start === $INFO['id']) {
                 // This is a start page, we return the namespace
                 $val = $ns;
             } else {

renderer/csv.php

@@ -168,7 +168,7 @@ public function emaillink($address, $name = null)
 
     public function plugin($name, $args, $state = '', $match = '')
     {
-        if (substr($name, 0, 7) == 'struct_') {
+        if (str_starts_with($name, 'struct_')) {
             parent::plugin($name, $args, $state, $match);
         } else {
             $this->cdata($match);

types/Decimal.php

@@ -81,7 +81,7 @@ public function renderValue($value, \Doku_Renderer $R, $mode)
                 $this->config['thousands']
             );
         }
-        if ($this->config['trimzeros'] && (strpos($value, (string) $this->config['decpoint']) !== false)) {
+        if ($this->config['trimzeros'] && (str_contains($value, (string) $this->config['decpoint']))) {
             $value = rtrim($value, '0');
             $value = rtrim($value, $this->config['decpoint']);
         }

types/Media.php

@@ -31,7 +31,7 @@ public function validate($rawvalue)
 
         [, $mime, ] = mimetype($rawvalue, false);
         foreach ($allows as $allow) {
-            if (strpos($mime, $allow) === 0) return $rawvalue;
+            if (str_starts_with($mime, $allow)) return $rawvalue;
         }
 
         throw new ValidationException('Media mime type', $mime, $this->config['mime']);
@@ -77,7 +77,7 @@ public function renderValue($value, \Doku_Renderer $R, $mode)
         // add gallery meta data in XHTML
         if ($mode == 'xhtml') {
             [, $mime, ] = mimetype($value, false);
-            if (substr($mime, 0, 6) == 'image/') {
+            if (str_starts_with($mime, 'image/')) {
                 $hash = empty($R->info['struct_table_hash']) ? '' : "[gal-" . $R->info['struct_table_hash'] . "]";
                 $html = str_replace('href', "rel=\"lightbox$hash\" href", $html);
             }