save unset data as empty string. #658

splitbrain · splitbrain · commit 2029240745a9 · 2023-08-09T10:41:05.000+02:00
Previous versions of the SQLite plugin (incorrectly) saved PHP null
values as empty strings. The new version correctly saves them as
database NULL. However for struct, we always want empty strings.
diff --git a/meta/AccessTablePage.php b/meta/AccessTablePage.php
@@ -34,7 +34,7 @@ public function clearData()
             if ($col->isMulti()) {
                 $data[$col->getLabel()] = array();
             } else {
-                $data[$col->getLabel()] = null;
+                $data[$col->getLabel()] = '';
             }
         }
 
diff --git a/meta/ValueValidator.php b/meta/ValueValidator.php
@@ -33,6 +33,8 @@ public function __construct()
      */
     public function validateValue(Column $col, &$rawvalue)
     {
+        if($rawvalue === null) $rawvalue = ''; // no data was passed
+
         // fix multi value types
         $type = $col->getType();
         $trans = $type->getTranslatedLabel();

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function clearData()`
`34`	`34`	`if ($col->isMulti()) {`
`35`	`35`	`$data[$col->getLabel()] = array();`
`36`	`36`	`} else {`
`37`		`- $data[$col->getLabel()] = null;`
	`37`	`+ $data[$col->getLabel()] = '';`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,8 @@ public function __construct()`
`33`	`33`	`*/`
`34`	`34`	`public function validateValue(Column $col, &$rawvalue)`
`35`	`35`	`{`
	`36`	`+ if($rawvalue === null) $rawvalue = ''; // no data was passed`
	`37`	`+`
`36`	`38`	`// fix multi value types`
`37`	`39`	`$type = $col->getType();`
`38`	`40`	`$trans = $type->getTranslatedLabel();`