Skip to content

Commit 6d71571

Browse files
authored
Merge pull request #217 from coroot/fix_mem_leak
prometheus: avoid retaining compression buffer between iterations
2 parents a632481 + 564d0ad commit 6d71571

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

prom/remote_writer.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ type Agent struct {
3535

3636
spoolDir string
3737
maxSpoolSize int64
38-
39-
compressionBuf []byte
4038
}
4139

4240
func StartAgent(reg *prometheus.Registry, machineId string) error {
@@ -169,9 +167,8 @@ func (a *Agent) scrape() error {
169167
return err
170168
}
171169

172-
a.compressionBuf = snappy.Encode(a.compressionBuf, decompressed)
173-
err = a.writeToSpool(timestamp, a.compressionBuf)
174-
a.compressionBuf = a.compressionBuf[:cap(a.compressionBuf)]
170+
compressed := snappy.Encode(nil, decompressed)
171+
err = a.writeToSpool(timestamp, compressed)
175172
return err
176173
}
177174

0 commit comments

Comments
 (0)