[13.0][FIX] sales_product_filter, change domain process to search in variants when comes from product template search

[cormaza]

Summary by Sourcery

Bug Fixes:

• Fix the product filtering to correctly filter by product variants when searching from a product template.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the way product template searches are performed when user-specific domain filters are applied. It introduces a new function to convert product template domain filters to product variant domain filters, ensuring that searches correctly consider product variants when filtering by user-specific domains.

Class diagram showing the modified ProductTemplate class

classDiagram
    class ProductTemplate {
        +name_search(name, args, operator, limit)
        +search(args, offset, limit, order, count)
        +add_product_variant_to_domain(args)
    }
    note for ProductTemplate "Modified search methods to
include variant filtering"

    class SaleProductFilter {
        +get_user_domains()
    }

    ProductTemplate ..> SaleProductFilter: uses

Loading

File-Level Changes

Change	Details	Files
Introduce a function to convert product template domain filters to product variant domain filters.	Added the add_product_variant_to_domain function to transform domain filters from product templates to product variants.	sales_product_filter/models/sale_order.py
Modify the name_search method to use the new function.	The name_search method now calls add_product_variant_to_domain to convert the domain filters before performing the search.	sales_product_filter/models/sale_order.py
Modify the search method to use the new function.	The search method now calls add_product_variant_to_domain to convert the domain filters before performing the search.	sales_product_filter/models/sale_order.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @cormaza - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a docstring to add_product_variant_to_domain() to document its purpose and parameters

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}