Skip to content

Deprecate alerts destinations #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
+18 −86
Merged

Deprecate alerts destinations #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/coralogix/v1beta1/alert_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,8 @@ type NotificationGroup struct {
// +optional
Webhooks []WebhookSettings `json:"webhooks"`

// The destinations for notifications (Notification Center feature).
// Do not use.
// Deprecated: This field is deprecated and will be removed in a future version.
// +optional
Destinations []NotificationDestination `json:"destinations,omitempty"`

Expand Down
10 changes: 6 additions & 4 deletions charts/coralogix-operator/templates/crds/coralogix.com_alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1809,8 +1809,9 @@ spec:
description: Where notifications should be sent to.
properties:
destinations:
description: The destinations for notifications (Notification
Center feature).
description: |-
Do not use.
Deprecated: This field is deprecated and will be removed in a future version.
items:
properties:
connector:
Expand Down Expand Up @@ -2092,8 +2093,9 @@ spec:
description: Notification group to use for alert notifications.
properties:
destinations:
description: The destinations for notifications (Notification
Center feature).
description: |-
Do not use.
Deprecated: This field is deprecated and will be removed in a future version.
items:
properties:
connector:
Expand Down
10 changes: 6 additions & 4 deletions config/crd/bases/coralogix.com_alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1809,8 +1809,9 @@ spec:
description: Where notifications should be sent to.
properties:
destinations:
description: The destinations for notifications (Notification
Center feature).
description: |-
Do not use.
Deprecated: This field is deprecated and will be removed in a future version.
items:
properties:
connector:
Expand Down Expand Up @@ -2092,8 +2093,9 @@ spec:
description: Notification group to use for alert notifications.
properties:
destinations:
description: The destinations for notifications (Notification
Center feature).
description: |-
Do not use.
Deprecated: This field is deprecated and will be removed in a future version.
items:
properties:
connector:
Expand Down
26 changes: 0 additions & 26 deletions config/samples/v1beta1/alerts/metric_threshold.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,29 +39,3 @@ spec:
integrationRef:
resourceRef:
name: slack-webhook
destinations:
- connector:
resourceRef:
name: slack-sample
preset:
backendRef:
id: preset_system_slack_alerts_basic
notifyOn: triggeredAndResolved
triggeredRoutingOverrides:
configOverrides:
payloadType: "slack_structured"
connectorConfigFields:
- fieldName: channel
template: "{{alertDef.priority}}"
messageConfigFields:
- fieldName: title
template: "TRIGGERED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}"
resolvedRoutingOverrides:
configOverrides:
payloadType: "slack_structured"
connectorConfigFields:
- fieldName: channel
template: "{{alertDef.priority}}"
messageConfigFields:
- fieldName: title
template: "RESOLVED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}"
6 changes: 4 additions & 2 deletions docs/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4478,7 +4478,8 @@ Where notifications should be sent to.
<td><b><a href="#alertspecnotificationgroupdestinationsindex">destinations</a></b></td>
<td>[]object</td>
<td>
The destinations for notifications (Notification Center feature).<br/>
Do not use.
Deprecated: This field is deprecated and will be removed in a future version.<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down Expand Up @@ -5297,7 +5298,8 @@ Notification group to use for alert notifications.
<td><b><a href="#alertspecnotificationgroupexcessindexdestinationsindex">destinations</a></b></td>
<td>[]object</td>
<td>
The destinations for notifications (Notification Center feature).<br/>
Do not use.
Deprecated: This field is deprecated and will be removed in a future version.<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down
49 changes: 0 additions & 49 deletions tests/e2e/alert_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,55 +87,6 @@ var _ = Describe("Alert", Ordered, func() {
},
},
},
Destinations: []coralogixv1beta1.NotificationDestination{
{
Connector: coralogixv1beta1.NCRef{
ResourceRef: &coralogixv1beta1.ResourceRef{
Name: connectorName,
},
},
Preset: &coralogixv1beta1.NCRef{
ResourceRef: &coralogixv1beta1.ResourceRef{
Name: presetName,
},
},
NotifyOn: coralogixv1beta1.NotifyOnTriggeredAndResolved,
TriggeredRoutingOverrides: coralogixv1beta1.NotificationRouting{
ConfigOverrides: &coralogixv1beta1.SourceOverrides{
PayloadType: "slack_structured",
ConnectorConfigFields: []coralogixv1beta1.ConfigField{
{
FieldName: "channel",
Template: "{{alertDef.priority}}",
},
},
MessageConfigFields: []coralogixv1beta1.ConfigField{
{
FieldName: "title",
Template: "TRIGGERED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}",
},
},
},
},
ResolvedRoutingOverrides: &coralogixv1beta1.NotificationRouting{
ConfigOverrides: &coralogixv1beta1.SourceOverrides{
PayloadType: "slack_structured",
ConnectorConfigFields: []coralogixv1beta1.ConfigField{
{
FieldName: "channel",
Template: "{{alertDef.priority}}",
},
},
MessageConfigFields: []coralogixv1beta1.ConfigField{
{
FieldName: "title",
Template: "RESOLVED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}",
},
},
},
},
},
},
},

Schedule: &coralogixv1beta1.AlertSchedule{
Expand Down
Loading