Deprecate alerts destinations

Author: assafad1

api/coralogix/v1beta1/alert_types.go

@@ -382,7 +382,8 @@ type NotificationGroup struct {
 	// +optional
 	Webhooks []WebhookSettings `json:"webhooks"`
 
-	// The destinations for notifications (Notification Center feature).
+	// Do not use.
+	// Deprecated: This field is deprecated and will be removed in a future version.
 	// +optional
 	Destinations []NotificationDestination `json:"destinations,omitempty"`
 

charts/coralogix-operator/templates/crds/coralogix.com_alerts.yaml

@@ -1809,8 +1809,9 @@ spec:
                 description: Where notifications should be sent to.
                 properties:
                   destinations:
-                    description: The destinations for notifications (Notification
-                      Center feature).
+                    description: |-
+                      Do not use.
+                      Deprecated: This field is deprecated and will be removed in a future version.
                     items:
                       properties:
                         connector:
@@ -2092,8 +2093,9 @@ spec:
                   description: Notification group to use for alert notifications.
                   properties:
                     destinations:
-                      description: The destinations for notifications (Notification
-                        Center feature).
+                      description: |-
+                        Do not use.
+                        Deprecated: This field is deprecated and will be removed in a future version.
                       items:
                         properties:
                           connector:

config/crd/bases/coralogix.com_alerts.yaml

@@ -1809,8 +1809,9 @@ spec:
                 description: Where notifications should be sent to.
                 properties:
                   destinations:
-                    description: The destinations for notifications (Notification
-                      Center feature).
+                    description: |-
+                      Do not use.
+                      Deprecated: This field is deprecated and will be removed in a future version.
                     items:
                       properties:
                         connector:
@@ -2092,8 +2093,9 @@ spec:
                   description: Notification group to use for alert notifications.
                   properties:
                     destinations:
-                      description: The destinations for notifications (Notification
-                        Center feature).
+                      description: |-
+                        Do not use.
+                        Deprecated: This field is deprecated and will be removed in a future version.
                       items:
                         properties:
                           connector:

config/samples/v1beta1/alerts/metric_threshold.yaml

@@ -39,29 +39,3 @@ spec:
           integrationRef:
             resourceRef:
               name: slack-webhook
-    destinations:
-      - connector:
-          resourceRef:
-            name: slack-sample
-        preset:
-          backendRef:
-            id: preset_system_slack_alerts_basic
-        notifyOn: triggeredAndResolved
-        triggeredRoutingOverrides:
-          configOverrides:
-            payloadType: "slack_structured"
-            connectorConfigFields:
-              - fieldName: channel
-                template: "{{alertDef.priority}}"
-            messageConfigFields:
-              - fieldName: title
-                template: "TRIGGERED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}"
-        resolvedRoutingOverrides:
-          configOverrides:
-            payloadType: "slack_structured"
-            connectorConfigFields:
-              - fieldName: channel
-                template: "{{alertDef.priority}}"
-            messageConfigFields:
-              - fieldName: title
-                template: "RESOLVED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}"

docs/api.md

@@ -4478,7 +4478,8 @@ Where notifications should be sent to.
         <td><b><a href="#alertspecnotificationgroupdestinationsindex">destinations</a></b></td>
         <td>[]object</td>
         <td>
-          The destinations for notifications (Notification Center feature).<br/>
+          Do not use.
+Deprecated: This field is deprecated and will be removed in a future version.<br/>
         </td>
         <td>false</td>
       </tr><tr>
@@ -5297,7 +5298,8 @@ Notification group to use for alert notifications.
         <td><b><a href="#alertspecnotificationgroupexcessindexdestinationsindex">destinations</a></b></td>
         <td>[]object</td>
         <td>
-          The destinations for notifications (Notification Center feature).<br/>
+          Do not use.
+Deprecated: This field is deprecated and will be removed in a future version.<br/>
         </td>
         <td>false</td>
       </tr><tr>

tests/e2e/alert_test.go

@@ -87,55 +87,6 @@ var _ = Describe("Alert", Ordered, func() {
 							},
 						},
 					},
-					Destinations: []coralogixv1beta1.NotificationDestination{
-						{
-							Connector: coralogixv1beta1.NCRef{
-								ResourceRef: &coralogixv1beta1.ResourceRef{
-									Name: connectorName,
-								},
-							},
-							Preset: &coralogixv1beta1.NCRef{
-								ResourceRef: &coralogixv1beta1.ResourceRef{
-									Name: presetName,
-								},
-							},
-							NotifyOn: coralogixv1beta1.NotifyOnTriggeredAndResolved,
-							TriggeredRoutingOverrides: coralogixv1beta1.NotificationRouting{
-								ConfigOverrides: &coralogixv1beta1.SourceOverrides{
-									PayloadType: "slack_structured",
-									ConnectorConfigFields: []coralogixv1beta1.ConfigField{
-										{
-											FieldName: "channel",
-											Template:  "{{alertDef.priority}}",
-										},
-									},
-									MessageConfigFields: []coralogixv1beta1.ConfigField{
-										{
-											FieldName: "title",
-											Template:  "TRIGGERED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}",
-										},
-									},
-								},
-							},
-							ResolvedRoutingOverrides: &coralogixv1beta1.NotificationRouting{
-								ConfigOverrides: &coralogixv1beta1.SourceOverrides{
-									PayloadType: "slack_structured",
-									ConnectorConfigFields: []coralogixv1beta1.ConfigField{
-										{
-											FieldName: "channel",
-											Template:  "{{alertDef.priority}}",
-										},
-									},
-									MessageConfigFields: []coralogixv1beta1.ConfigField{
-										{
-											FieldName: "title",
-											Template:  "RESOLVED PRESET OVERRIDE: {{alert.status}} {{alertDef.priority}} - {{alertDef.name}}",
-										},
-									},
-								},
-							},
-						},
-					},
 				},
 
 				Schedule: &coralogixv1beta1.AlertSchedule{