fixing metric-alert lessThan bug (#360)

OrNovo · web-flow · commit 39acff919667 · 2025-05-18T13:58:58.000+03:00
* fixing metric-alert lessTha bug

* adding support for lessThanOrEquals and moreThanOrEquals

* remove CHANGELOG.md
diff --git a/CHANGELOG.md b/CHANGELOG.md
diff --git a/api/coralogix/v1beta1/alert_types.go b/api/coralogix/v1beta1/alert_types.go
@@ -153,7 +153,7 @@ var (
 	}
 	MetricThresholdConditionTypeToProto = map[MetricThresholdConditionType]cxsdk.MetricThresholdConditionType{
 		MetricThresholdConditionTypeMoreThan:         cxsdk.MetricThresholdConditionTypeMoreThanOrUnspecified,
-		MetricThresholdConditionTypeLessThan:         cxsdk.MetricThresholdConditionTypeLessThanOrEquals,
+		MetricThresholdConditionTypeLessThan:         cxsdk.MetricThresholdConditionTypeLessThan,
 		MetricThresholdConditionTypeMoreThanOrEquals: cxsdk.MetricThresholdConditionTypeMoreThanOrEquals,
 		MetricThresholdConditionTypeLessThanOrEquals: cxsdk.MetricThresholdConditionTypeLessThanOrEquals,
 	}
@@ -891,7 +891,7 @@ const (
 	MetricTimeWindowValue36Hours   MetricTimeWindowSpecificValue = "36h"
 )
 
-// +kubebuilder:validation:Enum=moreThan;lessThan
+// +kubebuilder:validation:Enum=moreThan;lessThan;moreThanOrEquals;lessThanOrEquals
 // ConditionType type.
 type MetricThresholdConditionType string
 
diff --git a/charts/coralogix-operator/templates/crds/coralogix.com_alerts.yaml b/charts/coralogix-operator/templates/crds/coralogix.com_alerts.yaml
@@ -1313,6 +1313,8 @@ spec:
                                   enum:
                                   - moreThan
                                   - lessThan
+                                  - moreThanOrEquals
+                                  - lessThanOrEquals
                                   type: string
                                 forOverPct:
                                   format: int32
diff --git a/config/crd/bases/coralogix.com_alerts.yaml b/config/crd/bases/coralogix.com_alerts.yaml
@@ -1313,6 +1313,8 @@ spec:
                                   enum:
                                   - moreThan
                                   - lessThan
+                                  - moreThanOrEquals
+                                  - lessThanOrEquals
                                   type: string
                                 forOverPct:
                                   format: int32
diff --git a/docs/api.md b/docs/api.md
@@ -3425,7 +3425,7 @@ Conditions to match for the rule.
         <td>
           ConditionType type.<br/>
           <br/>
-            <i>Enum</i>: moreThan, lessThan<br/>
+            <i>Enum</i>: moreThan, lessThan, moreThanOrEquals, lessThanOrEquals<br/>
         </td>
         <td>true</td>
       </tr><tr>

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ var (`
`153`	`153`	`}`
`154`	`154`	`MetricThresholdConditionTypeToProto = map[MetricThresholdConditionType]cxsdk.MetricThresholdConditionType{`
`155`	`155`	`MetricThresholdConditionTypeMoreThan: cxsdk.MetricThresholdConditionTypeMoreThanOrUnspecified,`
`156`		`- MetricThresholdConditionTypeLessThan: cxsdk.MetricThresholdConditionTypeLessThanOrEquals,`
	`156`	`+ MetricThresholdConditionTypeLessThan: cxsdk.MetricThresholdConditionTypeLessThan,`
`157`	`157`	`MetricThresholdConditionTypeMoreThanOrEquals: cxsdk.MetricThresholdConditionTypeMoreThanOrEquals,`
`158`	`158`	`MetricThresholdConditionTypeLessThanOrEquals: cxsdk.MetricThresholdConditionTypeLessThanOrEquals,`
`159`	`159`	`}`
`@@ -891,7 +891,7 @@ const (`
`891`	`891`	`MetricTimeWindowValue36Hours MetricTimeWindowSpecificValue = "36h"`
`892`	`892`	`)`
`893`	`893`
`894`		`-// +kubebuilder:validation:Enum=moreThan;lessThan`
	`894`	`+// +kubebuilder:validation:Enum=moreThan;lessThan;moreThanOrEquals;lessThanOrEquals`
`895`	`895`	`// ConditionType type.`
`896`	`896`	`type MetricThresholdConditionType string`
`897`	`897`