Skip to content

Update README.md #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README.md #21

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7989044
Update README.md
mmcoralogix Jul 6, 2023
b5a2690
Merge branch 'master' into patch-1
ryantanjunming Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fluentbit/ecs-fargate/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This template provides a starting point for deploying Fluentbit as a sidecar con

### How to add Fluentbit as a sidecar container in an ECS Fargate task

ECS Fargate allows us to add a fluentbit container as a sidecar, the term sidecar here simply means that container is running in the same ECS task as the applcation container.
ECS Fargate allows us to add a fluentbit container as a sidecar, the term sidecar here simply means that the container is running in the same ECS task as the application container.

AWS supports adding Fluentbit as a sidecar using a FireLens configuration.

Expand All @@ -14,7 +14,7 @@ In order to configure Fluentbit as a sidecar container in an ECS Fargate task, y

When using the Fluentbit for AWS container image, you need to embed your configuration file in the Image itself. This is because the Fluentbit for AWS image already has a default configuration that is required for the integration to work. When we embed our configuration file in the image, it runs alongside the default configuration.

Once the your fluentbit image is created it needs to be pushed to ECR or any other publicy accessible container registry.
Once your fluentbit image is created it needs to be pushed to ECR or any other publically accessible container registry.
Copy link
Collaborator

@daidokoro daidokoro Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once your fluentbit image is created it needs to be pushed to ECR or any other publically accessible container registry.
Once your fluentbit image is created it needs to be pushed to ECR or any other publicly accessible container registry.

Copy link
Collaborator

@daidokoro daidokoro Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just a minor change here.


Create a configuration file. For example, extra.conf:

Expand Down Expand Up @@ -153,4 +153,4 @@ The JSON example above can be used to deploy via the AWS Console or API. Note th

When using this Cloudformation template you will need to modify it to suit your needs. You should start by replacing the [app container definition](template.yaml#72-#87) in the task to your own.

Once the template is modified, you can deploy it using the AWS Console or CLI.
Once the template is modified, you can deploy it using the AWS Console or CLI.