Skip to content

Update Collector Telemetry Metric Collection syntax in ECS-EC2 integration #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 18, 2025
Merged

Update Collector Telemetry Metric Collection syntax in ECS-EC2 integration #178

merged 11 commits into from
Mar 18, 2025

Conversation

@daidokoro
Copy link
Collaborator

@daidokoro daidokoro commented Mar 15, 2025 •
edited
Loading

  • Updates the collector telemetry metric collection configuration to the new syntax, as outlined here
  • Added transform to default otel ecs-ec2 config to remove unneeded labels caused by changing to the new syntax above.

Description

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's readme or docs change)

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@daidokoro daidokoro marked this pull request as ready for review March 15, 2025 14:50
@daidokoro daidokoro requested a review from a team as a code owner March 15, 2025 14:50
cazorla19
cazorla19 reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@cazorla19 cazorla19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting suggestions only, the logic itself LGTM

juan-coralogix
juan-coralogix reviewed Mar 17, 2025
View reviewed changes
daidokoro and others added 7 commits March 17, 2025 15:23
@daidokoro @cazorla19
Update opentelemetry/ecs-ec2-windows/template.yaml
7cd04dc 
Co-authored-by: Mikhail Chinkov <mikhail.chinkov@coralogix.com>
@daidokoro @cazorla19
Update opentelemetry/ecs-ec2-windows/template.yaml
1edb2ff 
Co-authored-by: Mikhail Chinkov <mikhail.chinkov@coralogix.com>
@daidokoro @cazorla19
Update opentelemetry/ecs-ec2/template.yaml
6a72b3a 
Co-authored-by: Mikhail Chinkov <mikhail.chinkov@coralogix.com>
@daidokoro
fix readme
e59f99d
@daidokoro @cazorla19
Update opentelemetry/ecs-ec2/CHANGELOG.md
207914c 
Co-authored-by: Mikhail Chinkov <mikhail.chinkov@coralogix.com>
@daidokoro
Merge branch 'master' into address-otel-breaking-change-119
6a84d0f
@daidokoro
Merge branch 'address-otel-breaking-change-119' of github.com:coralog…
8db8a89 
…ix/cloudformation-corlaogix-aws into address-otel-breaking-change-119
juan-coralogix
juan-coralogix approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daidokoro daidokoro merged commit d5bfab4 into master Mar 18, 2025
4 checks passed
@daidokoro daidokoro mentioned this pull request Mar 31, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cazorla19 cazorla19 cazorla19 left review comments

@juan-coralogix juan-coralogix juan-coralogix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daidokoro @CLAassistant @cazorla19 @juan-coralogix