Skip to content

Remove ECS-EC2 Deprecated cfn template parameter #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Remove ECS-EC2 Deprecated cfn template parameter #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e03034a
change log
daidokoro Apr 5, 2024
52b28b8
removed PrivateKey deprecate values
daidokoro Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions opentelemetry/ecs-ec2/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Changelog
### 0.0.11 / 2024-04-05
- Remove deprecated PrivateKey Param from ecs-ec2 otel deployment

### 0.0.10 / 2024-03-21
- [cds-1099] set default force_flush_period parameter to 0 for ecs-ec2 otel filelog receiver

Expand Down
5 changes: 2 additions & 3 deletions opentelemetry/ecs-ec2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ A GRPC(*4317*) and HTTP(*4318*) endpoint is exposed for sending traces to the lo
| ApplicationName | You application name | | :heavy_check_mark: |
| SubsystemName | You Subsystem name | AWS Account ID | :heavy_check_mark: |
| CoralogixApiKey | The Send-Your-Data API key for your Coralogix account. See: https://coralogix.com/docs/send-your-data-api-key/ | | :heavy_check_mark: |
| PrivateKey :warning::no_entry:__Deprecated__.:no_entry::warning: | :warning::no_entry:__Deprecated__.:no_entry::warning: Do not use. Hard-replaced by `CoralogixApiKey`. Must be null. Formerly: Your Coralogix Private Key. | | :no_entry: |
| Metrics | Enable/Disable Metrics | disable | |
| OtelConfig | The Base64 encoded Open Telemetry configuration yaml to use. This parameter allows you to pass your own Open Telemetry configuration. This will be used instead of the embedded configuration if specified. | | |

Expand All @@ -63,7 +62,7 @@ aws cloudformation deploy --template-file template.yaml --stack-name <stack_name
DefaultApplicationName=<application name> \
CDOTImageVersion=<image tag> \
ClusterName=<ecs cluster name> \
PrivateKey=<your-private-key> \
CoralogixApiKey=<your-private-key> \
CoralogixRegion=<coralogix-region>
```

Expand All @@ -76,7 +75,7 @@ aws cloudformation deploy --template-file cfn_template.yaml --stack-name <stack_
DefaultApplicationName=<application name> \
ClusterName=<ecs cluster name> \
CDOTImageVersion=<image tag> \
PrivateKey=<your-private-key> \
CoralogixApiKey=<your-private-key> \
OtelConfig=$(cat path/to/otelconfig.yaml | base64) \
CoralogixRegion=<coralogix-region>
```
Expand Down
7 changes: 0 additions & 7 deletions opentelemetry/ecs-ec2/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,6 @@ Parameters:
AllowedPattern: ".+"
ConstraintDescription: "API Key required."

PrivateKey:
Type: String
Description: "Deprecated. Do not use. Hard-replaced by \"CoralogixApiKey\". Formerly: The Coralogix private key which is used to validate your authenticity."
Default: "DO-NOT-USE"
AllowedPattern: "^DO-NOT-USE$" # hard-deprecate.
NoEcho: true

Metrics:
Type: String
Description: If true, cadivisor will be deployed on each node to collect metrics
Expand Down