Merge pull request #143 from coopdevs/fix-ansible-linter

FIX: Ansible linter

Author: danypr92

.yamllint.yaml

@@ -12,10 +12,10 @@ rules:
   document-start: disable
   empty-lines: {max: 3, level: error}
   hyphens: {level: error}
-  indentation: disable
+  indentation: enable
   key-duplicates: enable
   line-length: disable
-  new-line-at-end-of-file: disable
+  new-line-at-end-of-file: enable
   new-lines: {type: unix}
-  trailing-spaces: disable
-  truthy: disable
+  trailing-spaces: enable
+  truthy: enable

defaults/main.yml

@@ -45,10 +45,10 @@ odoo_role_odoo_db_admin_password: iT0ohDuoth6ONgahDeepaich0aeka5ul
 # Give the chance to select a database before login not filtered out by dbfilter, and enable db manager web interface.
 # In multi db mode, this is only relevant to db manager, as we force list_db to avoid an unaccessible website when dbfilter is disabled.
 # In single db mode,we disable dbfilter and respect list_db.
-odoo_role_list_db: False
+odoo_role_list_db: false
 # Security option that disables the web-base database manager and filters available DBs to list before login.
 # We ignore this setting in single DB mode to allow simpler db names such as "odoo" instead of domain name.
-odoo_role_dbfilter_enabled: True
+odoo_role_dbfilter_enabled: true
 
 # Comma-separated list of modules to install before running the server
 odoo_role_odoo_core_modules: "base"

meta/main.yml

@@ -8,11 +8,11 @@ galaxy_info:
   min_ansible_version: 1.2
 
   platforms:
-   - name: Ubuntu
-     versions:
-     - xenial
-     - bionic
-     - focal
+    - name: Ubuntu
+      versions:
+        - xenial
+        - bionic
+        - focal
 
   galaxy_tags:
     - odoo

tasks/add-service.yml

@@ -12,7 +12,7 @@
   become: true
   systemd:
     name: "{{ odoo_daemon }}"
-    enabled: yes
+    enabled: true
     state: started
-    daemon_reload: yes
+    daemon_reload: true
   notify: restart odoo

tasks/community-modules.yml

@@ -19,7 +19,7 @@
   # Using the output of pip, detect which packages have been installed,
   # both fresh or upgraded. Save the list with a register so that we can
   # feed better odoo with it.
-  
+
 - name: Detect upgraded packages
   args:
     # Example input (delete '# ' from each line below)
@@ -41,7 +41,7 @@
   # About sed:
   # - option `-r` switches to standard perl regexp, instead of GNU ones. Similar to `egrep` or `grep -E`
   # - option `-n` combined with flag `/p` prints "nothing" except the result of the script. Therefore, unmatching lines are hidden, and matching lines are shown after processed.
-  # - capturing groups `(something)` can be referenced inside the matching part or at the replacing part with \1, \2, in order of appearence. 
+  # - capturing groups `(something)` can be referenced inside the matching part or at the replacing part with \1, \2, in order of appearence.
   shell: >
     grep 'Successfully installed' |
     sed -r 's/ /\n/g' |

tasks/create-user.yml

@@ -1,22 +1,22 @@
 ---
 - name:  Create "{{ odoo_role_odoo_group }}" group
-  become: yes
+  become: true
   group:
     name: "{{ odoo_role_odoo_group }}"
     state: present
 
 - name: Create "{{ odoo_role_odoo_user }}" user
-  become: yes
+  become: true
   user:
     name: "{{ odoo_role_odoo_user }}"
     groups: "{{ odoo_role_odoo_group }}"
     group: "{{ odoo_role_odoo_group }}"
-    append: yes
+    append: true
     state: present
     shell: /bin/bash
 
 - name: "Create sudoers config for {{ odoo_role_odoo_user }} user"
-  become: yes
+  become: true
   template:
     dest: "/etc/sudoers.d/{{ odoo_role_odoo_user }}"
     mode: 0440

tasks/download.yml

@@ -46,7 +46,7 @@
     unarchive:
       src: "{{ odoo_role_odoo_download_path }}"
       dest: "{{ odoo_role_odoo_path }}"
-      remote_src: yes
+      remote_src: true
       owner: "{{ odoo_role_odoo_user }}"
       group: "{{ odoo_role_odoo_group }}"
       mode: 0775
@@ -58,13 +58,13 @@
 
 # Odoo from the OCA/OCB repository: https://github.com/OCA/OCB
 - name: "Git clone git reference {{ odoo_role_odoo_git_ref }}"
-  become: yes
+  become: true
   become_user: "{{ odoo_role_odoo_user }}"
   git:
     repo: "{{ odoo_role_odoo_git_url }}"
     dest: "{{ odoo_role_odoo_path }}"
     version: "{{ odoo_role_odoo_git_ref }}"
     depth: 1
-    force: yes
+    force: true
   register: odoo_role_desired_git_download
   when: odoo_role_download_strategy == "git"

tasks/logrotate.yml

@@ -3,4 +3,5 @@
     path: "/etc/logrotate.d/{{ item.path }}"
     block: "{{ item.conf }}"
     create: true
+    mode: 0644
   loop: "{{ odoo_role_logrotate_odoo }}"

tasks/main.yml

@@ -4,7 +4,7 @@
 - name: Install system packages
   become: true
   apt:
-    update_cache: yes
+    update_cache: true
     pkg:
       - build-essential
       - python3-dev
@@ -22,7 +22,7 @@
 - name: Install libjpeg-dev
   become: true
   apt:
-    update_cache: yes
+    update_cache: true
     pkg:
       - libjpeg-dev
     state: present
@@ -34,7 +34,7 @@
     executable: /bin/bash
   register: wkhtmltox_installed
   failed_when: false
-  changed_when: no
+  changed_when: false
 
 - name: Download and install wkhtmltopdf only if not already present at any version
   apt:
@@ -107,7 +107,7 @@
   npm:
     name: less
     version: 2.7.2
-    global: yes
+    global: true
   when: odoo_role_odoo_version < "12.0"
 
 # This link is needed in Ubuntu 16.04 and in Ubuntu 18.04 raise an error.

tasks/pyenv.yml

@@ -2,7 +2,7 @@
 - name: Ensure apt cache is up to date
   become: true
   apt:
-    update_cache: yes
+    update_cache: true
     cache_valid_time: "{{ 48 * 60 * 60 }}"  # consider the cache to be valid within 48 hours
 
 - name: Install development packages necessary for building Python
@@ -34,23 +34,23 @@
   git:
     repo: https://github.com/pyenv/pyenv.git
     dest: "/home/{{ odoo_role_odoo_user }}/pyenv"
-    update: no
+    update: false
 
 - name: Install PyEnv-virtualenv plugin
   become: true
   become_user: "{{ odoo_role_odoo_user }}"
   git:
     repo: https://github.com/yyuu/pyenv-virtualenv.git
     dest: "/home/{{ odoo_role_odoo_user }}/pyenv/plugins/pyenv-virtualenv"
-    update: no
+    update: false
 
 - name: Install PyEnv-update plugin
   become: true
   become_user: "{{ odoo_role_odoo_user }}"
   git:
     repo: https://github.com/pyenv/pyenv-update.git
     dest: "/home/{{ odoo_role_odoo_user }}/pyenv/plugins/pyenv-update"
-    update: no
+    update: false
 
 - name: Install .pyenvrc
   become: true