Use integers for packages.totalVolumeUnits(). Fixes #5002.

Author: alexsegura

app/DoctrineMigrations/Version20250522125927.php

@@ -0,0 +1,62 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Application\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+final class Version20250522125927 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return 'Use integers for "packages.totalVolumeUnits()" pricing expressions using "in" operator.';
+    }
+
+    public function up(Schema $schema): void
+    {
+        $stmt = $this->connection->prepare('SELECT id, expression FROM pricing_rule');
+
+        $result = $stmt->execute();
+        while ($pricingRule = $result->fetchAssociative()) {
+
+            if (1 === preg_match('/packages\.totalVolumeUnits\(\) in ([0-9\.]+)/', $pricingRule['expression'], $matches)) {
+
+                $range = $matches[1];
+
+                if (1 === preg_match('/([0-9\.]+)\.\.([0-9\.]+)/', $range, $rangeMatches)) {
+
+                    [ $whole, $start, $end ] = $rangeMatches;
+
+                    $hasFloat = false;
+
+                    if (false !== strpos($start, '.')) {
+                        $hasFloat = true;
+                        $start = (int) round((float) $start, 0, PHP_ROUND_HALF_ODD);
+                    }
+
+                    if (false !== strpos($end, '.')) {
+                        $hasFloat = true;
+                        $end = (int) round((float) $end, 0, PHP_ROUND_HALF_ODD);
+                    }
+
+                    if ($hasFloat) {
+                        $expression = str_replace($matches[0], sprintf('packages.totalVolumeUnits() in %d..%d', $start, $end), $pricingRule['expression']);
+
+                        $this->addSql('UPDATE pricing_rule SET expression = :expression WHERE id = :id', [
+                            'expression' => $expression,
+                            'id' => $pricingRule['id']
+                        ]);
+                    }
+                }
+            }
+        }
+
+    }
+
+    public function down(Schema $schema): void
+    {
+        $this->throwIrreversibleMigrationException();
+    }
+}

js/app/delivery/pricing/components/RulePickerLine/index.js

@@ -62,6 +62,17 @@ const formatValue = (value, type) => {
   return numbro.unformat(value) * (isK(type) ? 1000 : 1)
 }
 
+const getStepForType = (type) => {
+
+  // As it returns float, it will never work when comparing to floats
+  // https://github.com/coopcycle/coopcycle-web/issues/5002
+  if (type === 'packages.totalVolumeUnits()') {
+    return '1';
+  }
+
+  return '0.1';
+}
+
 class RulePickerLine extends React.Component {
 
   constructor (props) {
@@ -237,10 +248,10 @@ class RulePickerLine extends React.Component {
       return (
         <div className="d-flex justify-content-between">
           <div className="mr-2">
-            <input className="form-control input-sm" value={ (this.state.value[0] / (isK(this.state.type) ? 1000 : 1))  } onChange={this.handleFirstBoundChange} type="number" min="0" required step="0.1"></input>
+            <input className="form-control input-sm" value={ (this.state.value[0] / (isK(this.state.type) ? 1000 : 1))  } onChange={this.handleFirstBoundChange} type="number" min="0" required step={ getStepForType(this.state.type) }></input>
           </div>
           <div>
-            <input className="form-control input-sm" value={ (this.state.value[1] / (isK(this.state.type) ? 1000 : 1)) } onChange={this.handleSecondBoundChange} type="number" min="0" required step="0.1"></input>
+            <input className="form-control input-sm" value={ (this.state.value[1] / (isK(this.state.type) ? 1000 : 1)) } onChange={this.handleSecondBoundChange} type="number" min="0" required step={ getStepForType(this.state.type) }></input>
           </div>
         </div>
       )