Skip to content

Commit fa14b5b

Browse files
committed
Uses the symfony-pack image and build args can be empty
1 parent 3fe6ef8 commit fa14b5b

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

features/symfony.feature

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ Feature:
88
When I generate the configuration files
99
Then the generated "Dockerfile" file should look like:
1010
"""
11-
FROM quay.io/continuouspipe/symfony-flex:latest
12-
ARG APP_ENV
13-
ARG APP_DEBUG
14-
ARG APP_SECRET
11+
FROM quay.io/continuouspipe/symfony-pack:latest
12+
ARG APP_ENV=
13+
ARG APP_DEBUG=
14+
ARG APP_SECRET=
1515
COPY . /app/
1616
WORKDIR /app
1717
RUN container build

src/ConfigurationGeneration/Symfony/DockerGenerator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ public function generate(FilesystemInterface $filesystem, array $context) : arra
3737
}
3838

3939
$dockerFileLines = [
40-
'FROM quay.io/continuouspipe/symfony-flex:latest',
40+
'FROM quay.io/continuouspipe/symfony-pack:latest',
4141
];
4242

4343
foreach ($context['env'] as $key => $value) {
44-
$dockerFileLines[] = 'ARG '.$key;
44+
$dockerFileLines[] = 'ARG '.$key.'=';
4545
}
4646

4747
$dockerFileLines[] = 'COPY . /app/';

0 commit comments

Comments
 (0)