Skip to content

Commit 91a80c9

Browse files
author
Michel Bröker
committed
DN-34: Update to map.apps 4.18.1
1 parent f3dd507 commit 91a80c9

File tree

21 files changed

+191
-146
lines changed

21 files changed

+191
-146
lines changed

.eslintrc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"extends": "eslint-config-ct-prodeng",
3-
"plugins": [
4-
"vue"
5-
]
2+
"extends": "eslint-config-ct-prodeng",
3+
"plugins": [
4+
"vue"
5+
]
66
}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@
1414
/.vscode/settings.json
1515
/.externalToolBuilders/
1616
/package-lock.json
17+
/gulpfile.overrides.js

.stylelintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# add path patterns to ignore style files
2+
**/external-libs/**
3+
**/styles/dijit/**

.stylelintrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"extends": "stylelint-config-ct-prodeng"
3+
}

README.md

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,19 @@ Based on the Esri Cluster Layer JS provides here: https://github.com/Esri/cluste
1717
https://demos.conterra.de/mapapps/resources/apps/downloads_clusterfeaturelayer4/index.html
1818
https://demos.conterra.de/mapapps/resources/apps/downloads_clusterfeaturelayer4_2/index.html
1919

20-
## Development Guide
21-
### Define the mapapps remote base
22-
Before you can run the project you have to define the mapapps.remote.base property in the pom.xml-file:
23-
`<mapapps.remote.base>http://%YOURSERVER%/ct-mapapps-webapp-%VERSION%</mapapps.remote.base>`
24-
25-
### Other methods to to define the mapapps.remote.base property.
26-
1. Goal parameters
27-
`mvn install -Dmapapps.remote.base=http://%YOURSERVER%/ct-mapapps-webapp-%VERSION%`
28-
29-
2. Build properties
30-
Change the mapapps.remote.base in the build.properties file and run:
31-
`mvn install -Denv=dev -Dlocal.configfile=%ABSOLUTEPATHTOPROJECTROOT%/build.properties`
20+
## Quick start
21+
22+
Clone this project and ensure that you have all required dependencies installed correctly (see [Documentation](https://docs.conterra.de/en/mapapps/latest/developersguide/getting-started/set-up-development-environment.html)).
23+
24+
Then run the following commands from the project root directory to start a local development server:
25+
26+
```bash
27+
# install all required node modules
28+
$ mvn initialize
29+
30+
# start dev server
31+
$ mvn compile -Denv=dev -Pinclude-mapapps-deps
32+
33+
# run unit tests
34+
$ mvn test -P run-js-tests,include-mapapps-deps
35+
```

gulpfile.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,13 @@ mapapps.registerTasks({
6464
},
6565

6666
/* a list of themes inside this project */
67-
themes: [/*"sample-theme"*/],
67+
themes: [],
6868
/* state that the custom theme will be dependant from map.apps everlasting theme that provides the base styles */
6969
hasBaseThemes: true,
7070
/* state that we want to support vuetify components and therefore need the vuetify core styles*/
7171
hasVuetify: true,
7272
themeChangeTargets: {
73-
"vuetify": [
74-
// "sample_theme"
75-
]
73+
"vuetify": []
7674
},
7775
/* A list oft target browser versions. This should be streamlined with Esri JS API requirements. */
7876
transpileTargets: {
@@ -98,7 +96,12 @@ mapappsBrowserSync.registerTask({
9896

9997
// to prevent auto open of browser, set this to false
10098
urlToOpen: localOverrides?.openBrowser ?? true,
101-
99+
properties: {
100+
paths: [
101+
// Ensure @@key@@ expressions filtered in tests files
102+
/^\/js\/tests\/(runTests.html|test-init.js|init-packs.js)$/
103+
]
104+
},
102105
jsreg: {
103106
//npmDir : __dirname + "/node_modules/",
104107
npmModules: [
@@ -126,13 +129,14 @@ gulp.task("build",
126129
gulp.task("lint",
127130
gulp.parallel(
128131
"js-lint"
129-
//,"style-lint"
132+
/*, comment in to lint .css/.less files
133+
"style-lint"
134+
*/
130135
));
131136

132137
gulp.task("preview",
133138
gulp.series(
134139
"build",
135-
"lint",
136140
gulp.parallel(
137141
"watch",
138142
"browser-sync"

package.json

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,33 @@
44
"version": "0.0.1",
55
"license": "CC0-1.0",
66
"scripts": {
7-
"check-licenses": "node ./src/support/js/check-licenses.js"
7+
"check-licenses": "tsx ./src/support/js/check-licenses.ts",
8+
"check-types": "tsc --noEmit",
9+
"watch-types": "tsc -w --noEmit"
810
},
911
"devDependencies": {
10-
"@conterra/ct-mapapps-typings": "4.15.0",
11-
"@conterra/mapapps-mocha-runner": "^1.1.1",
12-
"@types/arcgis-js-api": "4.26.0",
13-
"chai": "^4.3.7",
14-
"ct-mapapps-browser-sync": "0.0.27",
15-
"ct-mapapps-gulp-js": "0.9.4",
16-
"eslint-config-ct-prodeng": "1.3.0-next-2",
17-
"license-checker": "^25.0.1",
18-
"mocha": "^10.2.0",
19-
"puppeteer": "^19.11.1",
20-
"vue-template-compiler": "2.7.8",
21-
"stylelint-config-ct-prodeng": "1.0.4",
22-
"stylelint-config-recommended": "5.0.0",
23-
"stylelint": "^13.13.1"
12+
"@conterra/ct-mapapps-typings": "~4.18.1",
13+
"@conterra/mapapps-mocha-runner": "1.1.1",
14+
"@conterra/reactivity-core": "^0.4.0",
15+
"@types/chai": "4.3.10",
16+
"@types/license-checker": "^25.0.6",
17+
"@types/mocha": "10.0.4",
18+
"arcgis-js-api": "4.29.10",
19+
"chai": "4.3.10",
20+
"ct-mapapps-browser-sync": "0.0.39",
21+
"ct-mapapps-gulp-js": "0.10.3",
22+
"eslint-config-ct-prodeng": "1.4.0",
23+
"license-checker": "25.0.1",
24+
"mocha": "10.2.0",
25+
"puppeteer": "21.5.2",
26+
"stylelint": "15.11.0",
27+
"stylelint-config-ct-prodeng": "2.0.0",
28+
"stylelint-config-recommended": "13.0.0",
29+
"stylelint-config-recommended-less": "2.0.0",
30+
"ts-node": "^10.9.1",
31+
"tsx": "^4.6.0",
32+
"typescript": "5.4.5",
33+
"vue": "2.7.15",
34+
"vue-template-compiler": "2.7.15"
2435
}
2536
}

0 commit comments

Comments
 (0)