Skip to content

Commit 92cdf3e

Browse files
committed
fix: regex method fixed for validation
1 parent abcd42d commit 92cdf3e

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### Version: 4.4.3
2+
#### Date: November-30-2024
3+
Fix: regex method fixed for validation
4+
15
### Version: 4.4.2
26
#### Date: November-16-2024
37
Fix: Variants reset issue fix on query call

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/delivery-sdk",
3-
"version": "4.4.2",
3+
"version": "4.4.3",
44
"type": "module",
55
"license": "MIT",
66
"main": "./dist/legacy/index.cjs",

src/lib/query.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ import { BaseQuery } from './base-query';
33
import { BaseQueryParameters, QueryOperation, QueryOperator, TaxonomyQueryOperation } from './types';
44
import { params, queryParams } from './internal-types';
55

6-
const safePatterns: RegExp[] = [
7-
/^[a-zA-Z0-9_.-]+$/, // Alphanumeric with underscores, periods, and dashes
8-
];
9-
106
export class Query extends BaseQuery {
117
private _contentTypeUid?: string;
128

@@ -34,10 +30,12 @@ export class Query extends BaseQuery {
3430

3531
// Validate if input matches any of the safe, pre-approved patterns
3632
private isValidRegexPattern(input: string): boolean {
37-
if (!this.isValidAlphanumeric(input)) {
38-
return false;
33+
try {
34+
new RegExp(input); // Try to create a new RegExp object
35+
return true; // No error means it's a valid regex
36+
} catch (e) {
37+
return false; // Error means it's not a valid regex
3938
}
40-
return safePatterns.some(pattern => pattern.test(input));
4139
}
4240

4341
private isValidValue(value: any[]): boolean {

0 commit comments

Comments
 (0)