Skip to content

Commit a22fbb8

Browse files
authored
Merge pull request #308 from contentstack/fix/DX-1292
fix: deploy command launch base url issue
2 parents 2e0b9b2 + 1e68121 commit a22fbb8

File tree

5 files changed

+40
-21
lines changed

5 files changed

+40
-21
lines changed

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ $ npm install -g @contentstack/apps-cli
2020
$ csdx COMMAND
2121
running command...
2222
$ csdx (--version|-v)
23-
@contentstack/apps-cli/1.3.2 darwin-arm64 node-v18.20.2
23+
@contentstack/apps-cli/1.3.3 darwin-arm64 node-v18.12.1
2424
$ csdx --help [COMMAND]
2525
USAGE
2626
$ csdx COMMAND
@@ -69,7 +69,7 @@ EXAMPLES
6969
$ csdx app:update
7070
```
7171

72-
_See code: [src/commands/app/index.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/index.ts)_
72+
_See code: [src/commands/app/index.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/index.ts)_
7373

7474
## `csdx app:create`
7575

@@ -109,7 +109,7 @@ EXAMPLES
109109
$ csdx app:create --name App-4 --app-type organization --org <UID> --boilerplate <Ecommerce App Boilerplate>
110110
```
111111

112-
_See code: [src/commands/app/create.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/create.ts)_
112+
_See code: [src/commands/app/create.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/create.ts)_
113113

114114
## `csdx app:delete`
115115

@@ -134,7 +134,7 @@ EXAMPLES
134134
$ csdx app:delete --app-uid <value> --org <value> -d ./boilerplate
135135
```
136136

137-
_See code: [src/commands/app/delete.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/delete.ts)_
137+
_See code: [src/commands/app/delete.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/delete.ts)_
138138

139139
## `csdx app:deploy`
140140

@@ -172,7 +172,7 @@ EXAMPLES
172172
$ csdx app:deploy --org <UID> --app-uid <APP-UID-1> --hosting-type <Hosting with Launch> --launch-project <new> --config <config-path>
173173
```
174174

175-
_See code: [src/commands/app/deploy.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/deploy.ts)_
175+
_See code: [src/commands/app/deploy.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/deploy.ts)_
176176

177177
## `csdx app:get`
178178

@@ -202,7 +202,7 @@ EXAMPLES
202202
$ csdx app:get --org <value> --app-uid <value> --app-type organization
203203
```
204204

205-
_See code: [src/commands/app/get.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/get.ts)_
205+
_See code: [src/commands/app/get.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/get.ts)_
206206

207207
## `csdx app:install`
208208

@@ -228,7 +228,7 @@ EXAMPLES
228228
$ csdx app:install --org <UID> --app-uid <APP-UID-1> --stack-api-key <STACK-API-KEY-1>
229229
```
230230

231-
_See code: [src/commands/app/install.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/install.ts)_
231+
_See code: [src/commands/app/install.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/install.ts)_
232232

233233
## `csdx app:reinstall`
234234

@@ -254,7 +254,7 @@ EXAMPLES
254254
$ csdx app:reinstall --org <UID> --app-uid <APP-UID-1> --stack-api-key <STACK-API-KEY-1>
255255
```
256256

257-
_See code: [src/commands/app/reinstall.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/reinstall.ts)_
257+
_See code: [src/commands/app/reinstall.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/reinstall.ts)_
258258

259259
## `csdx app:uninstall`
260260

@@ -281,7 +281,7 @@ EXAMPLES
281281
$ csdx app:uninstall --org <UID> --app-uid <APP-UID-1> --installation-uid <INSTALLATION-UID-1>
282282
```
283283

284-
_See code: [src/commands/app/uninstall.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/uninstall.ts)_
284+
_See code: [src/commands/app/uninstall.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/uninstall.ts)_
285285

286286
## `csdx app:update`
287287

@@ -304,5 +304,5 @@ EXAMPLES
304304
$ csdx app:update --app-manifest ./boilerplate/manifest.json
305305
```
306306

307-
_See code: [src/commands/app/update.ts](https://github.com/contentstack/apps-cli/blob/v1.3.2/src/commands/app/update.ts)_
307+
_See code: [src/commands/app/update.ts](https://github.com/contentstack/apps-cli/blob/v1.3.3/src/commands/app/update.ts)_
308308
<!-- commandsstop -->

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
],
2222
"dependencies": {
2323
"@apollo/client": "^3.7.9",
24-
"@contentstack/cli-command": "^1.2.19",
25-
"@contentstack/cli-launch": "^1.0.18",
26-
"@contentstack/cli-utilities": "^1.7.0",
24+
"@contentstack/cli-command": "~1.2.19",
25+
"@contentstack/cli-launch": "~1.2.0",
26+
"@contentstack/cli-utilities": "~1.7.0",
2727
"adm-zip": "^0.5.15",
2828
"chalk": "^4.1.2",
2929
"lodash": "^4.17.21",

src/commands/app/deploy.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {
2222
disconnectApp,
2323
formatUrl,
2424
handleProjectNameConflict,
25+
getLaunchHubUrl,
2526
} from "../../util";
2627

2728
export default class Deploy extends AppCLIBaseCommand {
@@ -167,9 +168,7 @@ export default class Deploy extends AppCLIBaseCommand {
167168
* @returns {Promise<ApolloClient>} The Apollo Client instance.
168169
*/
169170
async getApolloClient(projectUid = ""): Promise<ApolloClient<any>> {
170-
const baseUrl =
171-
config.launchBaseUrl ||
172-
(config.launchHubUrls as Record<string, string>)[this.cmaAPIUrl];
171+
const baseUrl = config.launchBaseUrl || getLaunchHubUrl();
173172
const manageApiBaseUrl = `${baseUrl}/${config.manageApiEndpoint}`;
174173
return await new GraphqlApiClient({
175174
headers: {

src/util/inquirer.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,25 @@ const validateAppName = (name: string) => {
409409
throw new Error($t(errors.INVALID_NAME, { min: "3", max: "20" }));
410410
}
411411
};
412+
413+
function getLaunchHubUrl(): string {
414+
const { cma } = configHandler.get('region') || {};
415+
if (!cma) {
416+
throw new Error('Region not configured. Please set the region with command $ csdx config:set:region');
417+
}
418+
419+
let launchHubBaseUrl = cma.replace('api', 'launch-api');
420+
421+
if (launchHubBaseUrl.startsWith('http')) {
422+
launchHubBaseUrl = launchHubBaseUrl.split('//')[1];
423+
}
424+
425+
launchHubBaseUrl = launchHubBaseUrl.startsWith('dev11') ? launchHubBaseUrl.replace('dev11', 'dev') : launchHubBaseUrl;
426+
launchHubBaseUrl = launchHubBaseUrl.endsWith('io') ? launchHubBaseUrl.replace('io', 'com') : launchHubBaseUrl;
427+
428+
return `https://${launchHubBaseUrl}`;
429+
}
430+
412431
export {
413432
getOrg,
414433
getAppName,
@@ -426,4 +445,5 @@ export {
426445
askProjectName,
427446
selectedBoilerplate,
428447
validateAppName,
448+
getLaunchHubUrl,
429449
};

0 commit comments

Comments
 (0)