fix: error handling, formatting and passing values to params

Author: harshithad0703

src/commands/app/reinstall.ts

@@ -105,11 +105,10 @@ export default class Reinstall extends AppCLIBaseCommand {
       await reinstallApp({
         flags: this.flags,
         type: appType,
-        orgUid: this.sharedConfig.org,
-        manifestUid: this.manifestData.uid,
-        configType: this.sharedConfig,
         developerHubBaseUrl: this.developerHubBaseUrl,
-      });
+      }, 
+      {orgUid: this.sharedConfig.org, manifestUid: this.manifestData.uid}
+      );
       this.log(
         $t(reinstallAppMsg.APP_REINSTALLED_SUCCESSFULLY, {
           app: app?.name || (this.flags["app-uid"] as string),

src/util/api-request-handler.ts

@@ -3,19 +3,19 @@ import { formatErrors } from "./error-helper";
 
 interface RequestParams {
   orgUid: string;
-  method: 'GET' | 'POST' | 'PUT' | 'DELETE';
+  method: "GET" | "POST" | "PUT" | "DELETE";
   queryParams?: Record<string, any>;
   payload?: any;
   url: string;
 }
 
 export async function apiRequestHandler(params: RequestParams): Promise<any> {
   const { orgUid, method, queryParams, payload, url } = params;
-  const authtoken = configHandler.get('authtoken');
+  const authtoken = configHandler.get("authtoken");
 
   const headers = {
     organization_uid: orgUid,
-    authtoken
+    authtoken,
   };
 
   const httpClient = new HttpClient();
@@ -27,13 +27,13 @@ export async function apiRequestHandler(params: RequestParams): Promise<any> {
 
   try {
     let response;
-    if (method === 'GET') {
+    if (method === "GET") {
       response = await httpClient.get(url);
-    } else if (method === 'POST') {
+    } else if (method === "POST") {
       response = await httpClient.post(url, payload);
-    } else if (method === 'PUT') {
+    } else if (method === "PUT") {
       response = await httpClient.put(url, payload);
-    } else if (method === 'DELETE') {
+    } else if (method === "DELETE") {
       response = await httpClient.delete(url);
     } else {
       throw new Error(`Unsupported HTTP method: ${method}`);
@@ -43,11 +43,10 @@ export async function apiRequestHandler(params: RequestParams): Promise<any> {
     if (status >= 200 && status < 300) {
       return data;
     }
-    data?.error
-      ? formatErrors(data.error)
-      : data?.error_message || 'Something went wrong';
-    throw data;
-    
+    const error_message = data?.error
+      ? formatErrors(data)
+      : data?.error_message || "Something went wrong";
+    throw error_message;
   } catch (error) {
     throw error;
   }

src/util/common-utils.ts

@@ -1,5 +1,5 @@
 import { ContentstackClient, FlagInput } from "@contentstack/cli-utilities";
-import { AppLocation, ConfigType, Extension, LogFn } from "../types";
+import { AppLocation, Extension, LogFn } from "../types";
 import { cliux, Stack } from "@contentstack/cli-utilities";
 import { apiRequestHandler } from "./api-request-handler";
 
@@ -138,13 +138,12 @@ function installApp(
 async function reinstallApp(params: {
   flags: FlagInput;
   type: string;
-  orgUid: string;
-  manifestUid: string;
-  configType: ConfigType;
   developerHubBaseUrl: string;
-}): Promise<void> {
-  const { type, orgUid, manifestUid, developerHubBaseUrl, flags } = params;
-
+}, 
+headers: { orgUid: string, manifestUid: string }
+): Promise<void> {
+  const { type, developerHubBaseUrl, flags } = params;
+  const {orgUid, manifestUid } = headers;
   const payload = {
     target_type: type,
     target_uid: (flags["stack-api-key"] as any) || orgUid,
@@ -153,8 +152,7 @@ async function reinstallApp(params: {
   const url = `https://${developerHubBaseUrl}/manifests/${manifestUid}/reinstall`;
   try {
     const result = await apiRequestHandler({
-      orgUid,
-      queryParams: params,
+      orgUid, 
       payload,
       url,
       method: "PUT"

src/util/error-helper.ts

@@ -1,18 +1,7 @@
 export function formatErrors(errors: any): string {
-  const errorMessages: string[] = [];
-  for (const errorKey in errors) {
-    const errorValue = errors[errorKey];
-    if (Array.isArray(errorValue)) {
-      errorMessages.push(...errorValue.map((error: any) => formatError(error)));
-    } else {
-      errorMessages.push(formatError(errorValue));
-    }
+  let errorMessage: string = "";
+  if (errors.message) {
+    errorMessage = errors.message;
   }
-  return errorMessages.join(" ");
-}
-function formatError(error: any): string {
-  if (typeof error === "object") {
-    return Object.values(error).join(" ");
-  }
-  return String(error);
+  return errorMessage;
 }