Skip to content

Commit 667ab69

Browse files
Merge pull request #2007 from contentstack/fix/back-merge-2
Fix/back merge 2
2 parents 0601b8e + 9473ef4 commit 667ab69

File tree

14 files changed

+489
-506
lines changed

14 files changed

+489
-506
lines changed

.talismanrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
fileignoreconfig:
22
- filename: pnpm-lock.yaml
3-
checksum: 612695c9e9d0a57c0996600c22ed44dc7929e926a619d30e753ab06310b22548
3+
checksum: f207dfb0198bc78f647a0a9456142fba670d49dc1b456bcf73de5e79ca0ec5d5
44
- filename: packages/contentstack-import/test/integration/auth-token-modules/environments.test.js
55
checksum: bc6f06b75d082aaf99e2f2f4b932b143765e2f14086967fb8973fe1b2ca6c03e
66
- filename: packages/contentstack-import/test/integration/environments.test.js
77
checksum: e71f033dad8944ffeafdf22d0514bda1d20c43e8fea0d62c96e774f3414beb31
88
- filename: package-lock.json
9-
checksum: 132bc404a7a90c907ac439d94289a1b83a0a0df56d617b3f697fc219a5b555a5
9+
checksum: 52bdeb0247e4b4e19510cd289f0baf1392000fbc64f06661291ffe08f440c89b
1010
- filename: packages/contentstack-auth/test/unit/tokens-validation.test.ts
1111
checksum: 676052e30d31a771ce68302d89b050d176bbef50f3abc7e9cdd4384f0e274e10
1212
- filename: packages/contentstack-import/test/integration/auth-token.test.js

package-lock.json

Lines changed: 436 additions & 433 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/contentstack-clone/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ $ npm install -g @contentstack/cli-cm-clone
1616
$ csdx COMMAND
1717
running command...
1818
$ csdx (--version)
19-
@contentstack/cli-cm-clone/1.14.2 darwin-x64 node-v22.17.0
19+
@contentstack/cli-cm-clone/1.14.3 darwin-arm64 node-v22.14.0
2020
$ csdx --help [COMMAND]
2121
USAGE
2222
$ csdx COMMAND

packages/contentstack-clone/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"dependencies": {
88
"@colors/colors": "^1.6.0",
99
"@contentstack/cli-cm-export": "~1.17.0",
10-
"@contentstack/cli-cm-import": "~1.25.0",
10+
"@contentstack/cli-cm-import": "~1.25.1",
1111
"@contentstack/cli-command": "~1.5.0",
1212
"@contentstack/cli-utilities": "~1.12.0",
1313
"@oclif/core": "^4.3.0",

packages/contentstack-import/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ $ npm install -g @contentstack/cli-cm-import
4747
$ csdx COMMAND
4848
running command...
4949
$ csdx (--version)
50-
@contentstack/cli-cm-import/1.24.0 darwin-x64 node-v22.17.0
50+
@contentstack/cli-cm-import/1.25.1 darwin-arm64 node-v22.14.0
5151
$ csdx --help [COMMAND]
5252
USAGE
5353
$ csdx COMMAND

packages/contentstack-import/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@contentstack/cli-cm-import",
33
"description": "Contentstack CLI plugin to import content into stack",
4-
"version": "1.25.0",
4+
"version": "1.25.1",
55
"author": "Contentstack",
66
"bugs": "https://github.com/contentstack/cli/issues",
77
"dependencies": {

packages/contentstack-import/src/import/modules/base-class.ts

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import { RoleData } from '@contentstack/management/types/stack/role';
1919

2020
import { log } from '../../utils';
2121
import { ImportConfig, ModuleClassParams } from '../../types';
22+
import cloneDeep from 'lodash/cloneDeep';
2223

2324
export type AdditionalKeys = {
2425
backupDir: string;
@@ -321,17 +322,23 @@ export default abstract class BaseClass {
321322
case 'update-cts':
322323
return apiData.update().then(onSuccess).catch(onReject);
323324
case 'create-gfs':
324-
return this.stack.globalField({api_version: '3.2'}).create(apiData).then(onSuccess).catch(onReject);
325+
return this.stack.globalField({ api_version: '3.2' }).create(apiData).then(onSuccess).catch(onReject);
325326
case 'update-gfs':
326327
let globalFieldUid = apiData.uid ?? apiData.global_field?.uid;
327-
return this.stack
328-
.globalField(globalFieldUid, {api_version: '3.2'})
329-
.fetch()
330-
.then(async (response) => {
331-
response.parent = apiData?.uid ? apiData : apiData.global_field;
332-
await response.update().then(onSuccess).catch(onReject);
333-
})
334-
.catch(onReject);
328+
return this.stack
329+
.globalField(globalFieldUid, { api_version: '3.2' })
330+
.fetch()
331+
.then(async (gf) => {
332+
const { uid, ...updatePayload } = cloneDeep(apiData);
333+
Object.assign(gf, updatePayload);
334+
try {
335+
const response = await gf.update();
336+
return onSuccess(response);
337+
} catch (error) {
338+
return onReject(error);
339+
}
340+
})
341+
.catch(onReject);
335342
case 'create-environments':
336343
return this.stack
337344
.environment()

packages/contentstack-import/src/import/modules/content-types.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@ export default class ContentTypesImport extends BaseClass {
127127
if (this.isExtensionsUpdate) {
128128
log(this.importConfig, 'Successfully updated the extensions.', 'success');
129129
}
130+
this.pendingGFs = fsUtil.readFile(this.gFsPendingPath) as any;
131+
if (!this.pendingGFs || isEmpty(this.pendingGFs)) {
132+
log(this.importConfig, 'No pending global fields found to update', 'info');
133+
return;
134+
}
130135
await this.updatePendingGFs().catch((error) => {
131136
log(this.importConfig, `Error while updating pending global field ${formatError(error)}`, 'error');
132137
});
@@ -227,8 +232,9 @@ export default class ContentTypesImport extends BaseClass {
227232

228233
async updatePendingGFs(): Promise<any> {
229234
this.pendingGFs = fsUtil.readFile(this.gFsPendingPath) as any;
235+
log(this.importConfig, `Found ${this.pendingGFs.length} pending global fields to update`, 'info');
230236
this.gFs = fsUtil.readFile(path.resolve(this.gFsFolderPath, this.gFsConfig.fileName)) as Record<string, unknown>[];
231-
const onSuccess = ({ response: globalField, apiData: { uid } = undefined }: any) => {
237+
const onSuccess = ({ response, apiData: { uid } = undefined }: any) => {
232238
log(this.importConfig, `Updated the global field ${uid} with content type references`, 'info');
233239
};
234240
const onReject = ({ error, apiData: { uid } = undefined }: any) => {
@@ -266,9 +272,7 @@ export default class ContentTypesImport extends BaseClass {
266272
this.importConfig.preserveStackVersion,
267273
this.installedExtensions,
268274
);
269-
const globalFieldPayload = this.stack.globalField(
270-
uid, { api_version: '3.2' },
271-
);
275+
const globalFieldPayload = this.stack.globalField(uid, { api_version: '3.2' });
272276
Object.assign(globalFieldPayload, cloneDeep(globalField));
273277
apiOptions.apiData = globalFieldPayload;
274278
return apiOptions;

packages/contentstack-import/src/import/modules/global-fields.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ export default class ImportGlobalFields extends BaseClass {
7676
).extension_uid;
7777

7878
await this.seedGFs();
79-
if (this.seedGFs?.length) fsUtil.writeFile(this.gFsPendingPath, this.pendingGFs);
8079
log(this.importConfig, 'Created Global Fields', 'success');
81-
80+
8281
await this.updateGFs();
82+
if (this.pendingGFs?.length) fsUtil.writeFile(this.gFsPendingPath, this.pendingGFs);
8383
log(this.importConfig, 'Updated Global Fields', 'success');
8484

8585
if (this.importConfig.replaceExisting && this.existingGFs.length > 0) {
@@ -178,6 +178,8 @@ export default class ImportGlobalFields extends BaseClass {
178178
await removeReferenceFields(globalField.schema, flag, this.stack);
179179
if (flag.supressed) {
180180
this.pendingGFs.push(globalField.uid);
181+
log(this.importConfig, `Global field '${globalField.uid}' will be updated later`, 'info');
182+
return resolve(true);
181183
}
182184
return this.stack
183185
.globalField(globalField.uid, { api_version: '3.2' })

packages/contentstack-import/src/utils/global-field-helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ export const gfSchemaTemplate = {
2222
"multiple": false
2323
}
2424
],
25-
"description": "Seed "
25+
"description": ""
2626
}
2727
};

0 commit comments

Comments
 (0)