Skip to content

Email service | UseHTML is never set #387

@adityathebe

Description

@adityathebe

When setting the content type to HTML in here

conf := service.config
var contentType string
if conf.UseHTML {
contentType = fmt.Sprintf(contentMultipart, service.multipartBoundary)
} else {
contentType = contentPlain
}

the config is read from the service struct. However, service.config.UseHTML is never populated.

What's populated is the clone of the config https://github.com/containrrr/shoutrrr/blob/main/pkg/services/smtp/smtp.go#L68-L71


I wanted to create a PR for this but running off the main branch gave me this error.

server did not accept the handshake: 555 5.5.2 Syntax error

Even checking out to the last commit in v0.8.0 gave me the same error. Not sure what's going on in here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions