Skip to content

Commit b93384c

Browse files
committed
fix(ip): mark requestMethod as optional
1 parent 315ac8d commit b93384c

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

api/v1/ip_types.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import (
2424

2525
type IPSpecIPSources struct {
2626
// URL of the IP source (e.g. https://checkip.amazonaws.com)
27-
// +optional
2827
URL string `json:"url,omitempty"`
2928
// RequestBody to be sent to the URL
3029
// +optional
@@ -38,7 +37,7 @@ type IPSpecIPSources struct {
3837
RequestHeadersSecretRef corev1.SecretReference `json:"requestHeadersSecretRef,omitempty"`
3938
// RequestMethod defines the HTTP method to be used
4039
// +kubebuilder:validation:Enum=GET;POST;PUT;DELETE
41-
// +kubebuilder:default=GET
40+
// +optional
4241
RequestMethod string `json:"requestMethod,omitempty"`
4342
// ResponseJQFilter applies a JQ filter to the response to extract the IP
4443
// +optional

config/crd/bases/cloudflare-operator.io_ips.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ spec:
9191
type: object
9292
x-kubernetes-map-type: atomic
9393
requestMethod:
94-
default: GET
9594
description: RequestMethod defines the HTTP method to be used
9695
enum:
9796
- GET

0 commit comments

Comments
 (0)