fix(ip): dynamic ip exponential backoff

Author: rxbn

internal/controller/ip_controller.go

@@ -24,7 +24,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"math/rand"
+	"math/rand/v2"
 	"net"
 	"net/http"
 	"net/url"
@@ -250,13 +250,14 @@ func (r *IPReconciler) handleDynamic(ctx context.Context, ip *cloudflareoperator
 	if len(ip.Spec.IPSources) == 0 {
 		return errors.New("IP sources are required for dynamic IPs")
 	}
-	if len(ip.Spec.IPSources) > 1 {
-		rand.Shuffle(len(ip.Spec.IPSources), func(i, j int) {
-			ip.Spec.IPSources[i], ip.Spec.IPSources[j] = ip.Spec.IPSources[j], ip.Spec.IPSources[i]
-		})
-	}
+	// DeepCopy the ip sources to avoid modifying the original slice which would cause the object to be updated on every reconcile
+	// which would lead to an infinite loop
+	ipSources := ip.Spec.DeepCopy().IPSources
+	rand.Shuffle(len(ipSources), func(i, j int) {
+		ipSources[i], ipSources[j] = ipSources[j], ipSources[i]
+	})
 	var ipSourceError error
-	for _, source := range ip.Spec.IPSources {
+	for _, source := range ipSources {
 		response, err := r.getIPSource(ctx, source)
 		if err != nil {
 			ipSourceError = err