chore: use const for statusconditions

Author: rxbn

internal/controller/account_controller.go

@@ -123,7 +123,7 @@ func (r *AccountReconciler) reconcileAccount(ctx context.Context, account *cloud
 
 	apimeta.SetStatusCondition(&account.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "True",
+		Status:             metav1.ConditionTrue,
 		Reason:             "Ready",
 		Message:            "Account is ready",
 		ObservedGeneration: account.Generation,
@@ -145,7 +145,7 @@ func (r *AccountReconciler) markFailed(account *cloudflareoperatoriov1.Account,
 	metrics.AccountFailureCounter.WithLabelValues(account.Name).Set(1)
 	apimeta.SetStatusCondition(&account.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "False",
+		Status:             metav1.ConditionFalse,
 		Reason:             "Failed",
 		Message:            err.Error(),
 		ObservedGeneration: account.Generation,

internal/controller/dnsrecord_controller.go

@@ -151,20 +151,20 @@ func (r *DNSRecordReconciler) reconcileDNSRecord(ctx context.Context, dnsrecord
 	if r.Cf.APIToken == "" {
 		apimeta.SetStatusCondition(&dnsrecord.Status.Conditions, metav1.Condition{
 			Type:               "Ready",
-			Status:             "False",
+			Status:             metav1.ConditionFalse,
 			Reason:             "NotReady",
-			Message:            "Cloudflare account is not yet ready",
+			Message:            "Cloudflare account is not ready",
 			ObservedGeneration: dnsrecord.Generation,
 		})
 		return ctrl.Result{RequeueAfter: time.Second * 5}
 	}
 
-	if condition := apimeta.FindStatusCondition(zone.Status.Conditions, "Ready"); condition == nil || condition.Status != "True" {
+	if condition := apimeta.FindStatusCondition(zone.Status.Conditions, "Ready"); condition == nil || condition.Status != metav1.ConditionTrue {
 		apimeta.SetStatusCondition(&dnsrecord.Status.Conditions, metav1.Condition{
 			Type:               "Ready",
-			Status:             "False",
+			Status:             metav1.ConditionFalse,
 			Reason:             "NotReady",
-			Message:            "Zone is not yet ready",
+			Message:            "Zone is not ready",
 			ObservedGeneration: dnsrecord.Generation,
 		})
 		return ctrl.Result{RequeueAfter: time.Second * 5}
@@ -242,7 +242,7 @@ func (r *DNSRecordReconciler) reconcileDNSRecord(ctx context.Context, dnsrecord
 
 	apimeta.SetStatusCondition(&dnsrecord.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "True",
+		Status:             metav1.ConditionTrue,
 		Reason:             "Ready",
 		Message:            "DNS record synced",
 		ObservedGeneration: dnsrecord.Generation,
@@ -269,7 +269,7 @@ func (r *DNSRecordReconciler) markFailed(dnsrecord *cloudflareoperatoriov1.DNSRe
 	metrics.DnsRecordFailureCounter.WithLabelValues(dnsrecord.Namespace, dnsrecord.Name, dnsrecord.Spec.Name).Set(1)
 	apimeta.SetStatusCondition(&dnsrecord.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "False",
+		Status:             metav1.ConditionFalse,
 		Reason:             "Failed",
 		Message:            err.Error(),
 		ObservedGeneration: dnsrecord.Generation,

internal/controller/ip_controller.go

@@ -121,7 +121,7 @@ func (r *IPReconciler) reconcileIP(ctx context.Context, ip *cloudflareoperatorio
 
 	apimeta.SetStatusCondition(&ip.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "True",
+		Status:             metav1.ConditionTrue,
 		Reason:             "Ready",
 		Message:            "IP is ready",
 		ObservedGeneration: ip.Generation,
@@ -290,7 +290,7 @@ func (r *IPReconciler) markFailed(ip *cloudflareoperatoriov1.IP, err error) {
 	metrics.IpFailureCounter.WithLabelValues(ip.Name, ip.Spec.Type).Set(1)
 	apimeta.SetStatusCondition(&ip.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "False",
+		Status:             metav1.ConditionFalse,
 		Reason:             "Failed",
 		Message:            err.Error(),
 		ObservedGeneration: ip.Generation,

internal/controller/zone_controller.go

@@ -109,9 +109,9 @@ func (r *ZoneReconciler) reconcileZone(ctx context.Context, zone *cloudflareoper
 	if r.Cf.APIToken == "" {
 		apimeta.SetStatusCondition(&zone.Status.Conditions, metav1.Condition{
 			Type:               "Ready",
-			Status:             "False",
+			Status:             metav1.ConditionFalse,
 			Reason:             "NotReady",
-			Message:            "Cloudflare account is not yet ready",
+			Message:            "Cloudflare account is not ready",
 			ObservedGeneration: zone.Generation,
 		})
 		return ctrl.Result{RequeueAfter: time.Second * 5}
@@ -133,7 +133,7 @@ func (r *ZoneReconciler) reconcileZone(ctx context.Context, zone *cloudflareoper
 
 	apimeta.SetStatusCondition(&zone.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "True",
+		Status:             metav1.ConditionTrue,
 		Reason:             "Ready",
 		Message:            "Zone is ready",
 		ObservedGeneration: zone.Generation,
@@ -191,7 +191,7 @@ func (r *ZoneReconciler) markFailed(zone *cloudflareoperatoriov1.Zone, err error
 	metrics.ZoneFailureCounter.WithLabelValues(zone.Name, zone.Spec.Name).Set(1)
 	apimeta.SetStatusCondition(&zone.Status.Conditions, metav1.Condition{
 		Type:               "Ready",
-		Status:             "False",
+		Status:             metav1.ConditionFalse,
 		Reason:             "Failed",
 		Message:            err.Error(),
 		ObservedGeneration: zone.Generation,