Skip to content

Commit 3b42bf6

Browse files
committed
chore: order functions
1 parent 2ee35f6 commit 3b42bf6

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

internal/controller/dnsrecord_controller.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -232,17 +232,6 @@ func (r *DNSRecordReconciler) reconcileDNSRecord(ctx context.Context, dnsrecord
232232
return ctrl.Result{RequeueAfter: dnsrecord.Spec.Interval.Duration}
233233
}
234234

235-
// reconcileDelete reconciles the deletion of the dnsrecord
236-
func (r *DNSRecordReconciler) reconcileDelete(ctx context.Context, zoneID string, dnsrecord *cloudflareoperatoriov1.DNSRecord) error {
237-
if err := r.Cf.DeleteDNSRecord(ctx, cloudflare.ZoneIdentifier(zoneID), dnsrecord.Status.RecordID); err != nil && err.Error() != "Record does not exist. (81044)" {
238-
return err
239-
}
240-
metrics.DnsRecordFailureCounter.DeleteLabelValues(dnsrecord.Namespace, dnsrecord.Name, dnsrecord.Spec.Name)
241-
controllerutil.RemoveFinalizer(dnsrecord, common.CloudflareOperatorFinalizer)
242-
243-
return nil
244-
}
245-
246235
// comparePriority compares the priority nil safe
247236
func comparePriority(a, b *uint16) bool {
248237
if a == nil && b == nil {
@@ -325,3 +314,14 @@ func (r *DNSRecordReconciler) requestsForIPChange(ctx context.Context, o client.
325314
}
326315
return reqs
327316
}
317+
318+
// reconcileDelete reconciles the deletion of the dnsrecord
319+
func (r *DNSRecordReconciler) reconcileDelete(ctx context.Context, zoneID string, dnsrecord *cloudflareoperatoriov1.DNSRecord) error {
320+
if err := r.Cf.DeleteDNSRecord(ctx, cloudflare.ZoneIdentifier(zoneID), dnsrecord.Status.RecordID); err != nil && err.Error() != "Record does not exist. (81044)" {
321+
return err
322+
}
323+
metrics.DnsRecordFailureCounter.DeleteLabelValues(dnsrecord.Namespace, dnsrecord.Name, dnsrecord.Spec.Name)
324+
controllerutil.RemoveFinalizer(dnsrecord, common.CloudflareOperatorFinalizer)
325+
326+
return nil
327+
}

0 commit comments

Comments
 (0)