Skip to content

Commit 8caf5ec

Browse files
authored
Merge pull request #233 from jokemanfire/dev2
If streams cannot be locked, it will cause a panic
2 parents 80d4ff4 + 00de628 commit 8caf5ec

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/asynchronous/client.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,10 @@ impl Client {
7676

7777
let (tx, mut rx): (ResultSender, ResultReceiver) = mpsc::channel(100);
7878

79-
// TODO: check return.
80-
self.streams.lock().unwrap().insert(stream_id, tx);
79+
self.streams
80+
.lock()
81+
.map_err(|_| Error::Others("Failed to acquire lock on streams".to_string()))?
82+
.insert(stream_id, tx);
8183

8284
self.req_tx
8385
.send(SendingMessage::new(msg))
@@ -138,8 +140,11 @@ impl Client {
138140
}
139141

140142
let (tx, rx): (ResultSender, ResultReceiver) = mpsc::channel(100);
141-
// TODO: check return
142-
self.streams.lock().unwrap().insert(stream_id, tx);
143+
self.streams
144+
.lock()
145+
.map_err(|_| Error::Others("Failed to acquire lock on streams".to_string()))?
146+
.insert(stream_id, tx);
147+
143148
self.req_tx
144149
.send(SendingMessage::new(msg))
145150
.await

0 commit comments

Comments
 (0)