Moved shutdown outside of mutex lock

cliffg-softwarelibre · cliffg-softwarelibre · commit 6bfaf4bc1370 · 2024-06-09T19:10:08.000-06:00
diff --git a/test/wait_queue_test.cpp b/test/wait_queue_test.cpp
@@ -164,10 +164,10 @@ bool threaded_test(Q& wq, int num_readers, int num_writers, int slice, const T&
     std::this_thread::sleep_for(std::chrono::seconds(1));
     std::lock_guard<std::mutex> lk(mut);
     if (s.size() == tot) {
-      wq.request_stop(); // tell the readers it's done
       done = true;
     }
   }
+  wq.request_stop(); // tell the readers it's done
 
   // join readers; since wait queue is stopped they should all join immediately
   for (auto& thr : rd_thrs) {

Original file line number	Diff line number	Diff line change
`@@ -164,10 +164,10 @@ bool threaded_test(Q& wq, int num_readers, int num_writers, int slice, const T&`
`164`	`164`	`std::this_thread::sleep_for(std::chrono::seconds(1));`
`165`	`165`	`std::lock_guard<std::mutex> lk(mut);`
`166`	`166`	`if (s.size() == tot) {`
`167`		`- wq.request_stop(); // tell the readers it's done`
`168`	`167`	`done = true;`
`169`	`168`	`}`
`170`	`169`	`}`
	`170`	`+ wq.request_stop(); // tell the readers it's done`
`171`	`171`
`172`	`172`	`// join readers; since wait queue is stopped they should all join immediately`
`173`	`173`	`for (auto& thr : rd_thrs) {`