Working on wp_access Windows errors

Author: cliffg-softwarelibre

README.md

@@ -64,7 +64,7 @@ To build and run the unit test programs:
 First clone the `chops-net-ip` repository, then create a build directory in parallel to the `chops-net-ip` directory (this is called "out of source" builds, which is recommended), then `cd` (change directory) into the build directory. The CMake commands:
 
 ```
-cmake -D CHOPS_NET_IP_BUILD_TESTS:BOOL=ON ../chops_net_ip
+cmake -D CHOPS_NET_IP_BUILD_TESTS:BOOL=ON ../chops-net-ip
 
 cmake --build .
 

include/net_ip/net_entity.hpp

@@ -168,9 +168,10 @@ class net_entity {
  *  Within the function object socket options can be queried or modified or any valid
  *  socket method called.
  *
- *  @return @c nonstd::expected - socket has been visited on success; on error (if no 
+ *  @return @c nonstd::expected - @c bool socket has been visited; on error (if no 
  *  associated IO handler), a @c std::error_code is returned.
  */
+
   template <typename F>
   auto visit_socket(F&& func) const ->
           nonstd::expected<void, std::error_code> {

test/net_ip/detail/CMakeLists.txt

@@ -14,8 +14,8 @@ set ( test_app_names  io_common_test
                       tcp_acceptor_test
                       tcp_connector_test
 		      tcp_io_test
-		      udp_entity_io_test
-                      wp_access_test )
+		      udp_entity_io_test 
+		      wp_access_test )
 
 include ( ../../../cmake/test_app_creation.cmake )
 

test/net_ip/detail/wp_access_test.cpp

@@ -53,35 +53,31 @@ TEST_CASE ("Weak pointer pointing to default constructed net_entity_mock") {
     REQUIRE_FALSE (*r);
   }
 
-    AND_WHEN ("start is called followed by is_started followed by stop") {
-      THEN ("all calls succeed") {
-        auto r1 = chops::net::detail::wp_access_void(wp,
-            [] (ne_sp nesp) { return nesp->start(chops::test::io_state_chg_mock, chops::test::err_func_mock ); }
-        );
-        REQUIRE (r1);
-        auto r2 = chops::net::detail::wp_access<bool>(wp, [] (ne_sp nesp) { return nesp->is_started(); } );
-        REQUIRE (r2);
-        REQUIRE(*r2);
-        auto r3 = chops::net::detail::wp_access_void(wp, [] (ne_sp nesp) { return nesp->stop(); } );
-        REQUIRE (r3);
-        auto r4 = chops::net::detail::wp_access<bool>(wp, [] (ne_sp nesp) { return nesp->is_started(); } );
-        REQUIRE (r4);
-        REQUIRE_FALSE(*r4);
-      }
-    }
-    AND_WHEN ("visit_io_output is called") {
-      THEN ("the call succeeds with the correct return value") {
-        auto r = chops::net::detail::wp_access<std::size_t>(wp,
-            [] (ne_sp nesp) { return nesp->visit_io_output(
-                [] (chops::net::basic_io_output<chops::test::io_handler_mock>) { } ); 
-            }
-        );
-        REQUIRE (r);
-        REQUIRE (*r == 1u);
-      }
-    }
-  } // end given
+  SECTION ("Calling start followed by stop should return false for is_started") {
+    auto r1 = chops::net::detail::wp_access_void(wp,
+        [] (ne_sp nesp) { return nesp->start(chops::test::io_state_chg_mock, chops::test::err_func_mock ); }
+    );
+    REQUIRE (r1);
+    auto r2 = chops::net::detail::wp_access<bool>(wp, [] (ne_sp nesp) { return nesp->is_started(); } );
+    REQUIRE (r2);
+    REQUIRE(*r2);
+    auto r3 = chops::net::detail::wp_access_void(wp, [] (ne_sp nesp) { return nesp->stop(); } );
+    REQUIRE (r3);
+    auto r4 = chops::net::detail::wp_access<bool>(wp, [] (ne_sp nesp) { return nesp->is_started(); } );
+    REQUIRE (r4);
+    REQUIRE_FALSE(*r4);
+  }
 
+  SECTION ("When visit_io_output the correct return value should be returned") {
+    auto r = chops::net::detail::wp_access<std::size_t>(wp,
+        [] (ne_sp nesp) { return nesp->visit_io_output(
+            [] (chops::net::basic_io_output<chops::test::io_handler_mock>) { } ); 
+        }
+    );
+    REQUIRE (r);
+    REQUIRE (*r == 1u);
+  }
 }
 
 
+