[APIT-2483] Update docs for Private Link Attachment / Private Link Attachment Connection to indicate that display_name is required (#434)

* Update docs for PLA / PLAC to indicate that display_name is required

* Update code for PLA / PLAC to indicate display_name is required

* Add more fix to the required display_name field

* Removed the Computed field

* small fix

Author: cqin-confluent

docs/resources/confluent_private_link_attachment.md

@@ -34,7 +34,7 @@ output "private_link_attachment" {
 
 The following arguments are supported:
 
-- `display_name` - (Optional String) The name of the Private Link Attachment.
+- `display_name` - (Required String) The name of the Private Link Attachment.
 - `environment` (Required Configuration Block) supports the following:
   - `id` - (Required String) The ID of the Environment that the Private Link Attachment belongs to, for example `env-xyz456`.
 - `cloud` - (Required String) The cloud service provider that hosts the resources to access with the Private Link Attachment.

docs/resources/confluent_private_link_attachment_connection.md

@@ -51,7 +51,7 @@ output "private_link_attachment_connection" {
 
 The following arguments are supported:
 
-- `display_name` - (Optional String) The name of the Private Link Attachment Connection.
+- `display_name` - (Required String) The name of the Private Link Attachment Connection.
 - `environment` (Required Configuration Block) supports the following:
   - `id` - (Required String) The ID of the Environment that the Private Link Attachment Connection belongs to, for example `env-xyz456`.
 - `private_link_attachment` (Required Configuration Block) supports the following:

internal/provider/resource_private_link_attachment.go

@@ -38,10 +38,10 @@ func privateLinkAttachmentResource() *schema.Resource {
 		},
 		Schema: map[string]*schema.Schema{
 			paramDisplayName: {
-				Type:        schema.TypeString,
-				Description: "The name of the Private Link Attachment.",
-				Optional:    true,
-				Computed:    true,
+				Type:         schema.TypeString,
+				Description:  "The name of the Private Link Attachment.",
+				Required:     true,
+				ValidateFunc: validation.StringIsNotEmpty,
 			},
 			paramCloud: {
 				Type:         schema.TypeString,

internal/provider/resource_private_link_attachment_connection.go

@@ -22,6 +22,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-log/tflog"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	"net/http"
 	"strings"
 )
@@ -49,10 +50,10 @@ func privateLinkAttachmentConnectionResource() *schema.Resource {
 		},
 		Schema: map[string]*schema.Schema{
 			paramDisplayName: {
-				Type:        schema.TypeString,
-				Description: "The name of the Private Link Attachment Connection.",
-				Optional:    true,
-				Computed:    true,
+				Type:         schema.TypeString,
+				Description:  "The name of the Private Link Attachment Connection.",
+				Required:     true,
+				ValidateFunc: validation.StringIsNotEmpty,
 			},
 			paramResourceName: {
 				Type:     schema.TypeString,