Windows CMake build and curl

[StephenSmith25]

Hey,

Just trying to build the library on windows using CMake, but facing a few issues when I enable CURL with regards to missing symbols, e.g:

__imp_curl_global_init__

Maybe I'm missing something, but I can't find in CMake where we link to the curl libraries? Anyone have any ideas / what I've missed / what I'm doing wrong?

[StephenSmith25]

Think we just need to add,

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 33b3ced1..31783569 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -200,6 +200,10 @@ if(WITH_HDRHISTOGRAM)
   target_link_libraries(rdkafka PUBLIC m)
 endif()
 
+if(WITH_CURL)
+    target_link_libraries(rdkafka PRIVATE ${CURL_LIBRARIES})
+endif()
+
 if(WITH_ZLIB)
   find_package(ZLIB REQUIRED)
   target_include_directories(rdkafka PRIVATE ${ZLIB_INCLUDE_DIRS})

[StephenSmith25]

Ah never mind - didn't see #3893 - Apologies - I guess this will be addressed shortly.