a lot of bogus LogEvents when using go-channel

[amills-vibeirl]

Description

        chanLogs := make(chan kafka.LogEvent)

	defer func() {
		close(chanLogs)
	}()

	go func() {
		for {
			logEv := <-chanLogs
			vibelog.Stdout.Info("kafka admin -", logEv)
		}
	}()

	adminClient, err := kafka.NewAdminClient(&kafka.ConfigMap{
		"bootstrap.servers": "0.0.0.0:9092",
		"go.logs.channel":        chanLogs,
		"go.logs.channel.enable": true,
	})

with the above setup, I get a bunch of "bogus" events logged:

00:24:17.95033 INFO app:Vibe:Chat kafka admin - LogEvent {
  Name: '', 
  Tag: '', 
  Message: '', 
  Level: 0, 
  Timestamp: Time {
   wall: 0, 
   ext: 0, 
   loc: UTC
  }
 } 

00:24:17.95044 INFO app:Vibe:Chat kafka admin - LogEvent {
  Name: '', 
  Tag: '', 
  Message: '', 
  Level: 0, 
  Timestamp: Time {
   wall: 0, 
   ext: 0, 
   loc: UTC
  }
 } 


00:24:17.95053 INFO app:Vibe:Chat kafka admin - LogEvent {
  Name: '', 
  Tag: '', 
  Message: '', 
  Level: 0, 
  Timestamp: Time {
   wall: 0, 
   ext: 0, 
   loc: UTC
  }
 } 

am I doing this wrong?

[amills-vibeirl]

specifically this happens with the AdminClient, not the other clients, it appears!! This same technique works fine with the Consumer/Producer clients, (not a ton of bogus log events)

[milindl]

Thanks @amills-vibeirl for reporting this. Yeah, it seems to be an issue, the admin client doesn't seem to handle the logs channel internally.

I can suggest a workaround while we fix it.

	p, err := kafka.NewProducer(&kafka.ConfigMap{
		"bootstrap.servers":      "localhost:9092",
		"go.logs.channel":        chanLogs,
		"go.logs.channel.enable": true,
	})
	// check the error and stop if not nil.
	adminClient, err := kafka.NewAdminClientFromProducer(p)

The producer should be closed after you are done using the adminClient, but not before it.
ie

adminClient.Close()
p.Close()

(You don't need to use the producer for anything else, a new one can be created and used just for this purpose)