Skip to content

Commit 790c387

Browse files
ideasculptorSamuel Gendlerrayokota
authored
bugfix: update protobuf.Deserializer to use base class implementation of ConfigureDeserializer (#970)
Co-authored-by: Samuel Gendler <sam@yalo.com> Co-authored-by: Robert Yokota <rayokota@gmail.com>
1 parent 32f065e commit 790c387

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

schemaregistry/serde/protobuf/protobuf.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,9 @@ func (s *Deserializer) ConfigureDeserializer(client schemaregistry.Client, serde
156156
if client == nil {
157157
return fmt.Errorf("schema registry client missing")
158158
}
159-
s.Client = client
160-
s.Conf = conf
161-
s.SerdeType = serdeType
162-
s.SubjectNameStrategy = serde.TopicNameStrategy
159+
if err := s.BaseDeserializer.ConfigureDeserializer(client, serdeType, conf); err != nil {
160+
return err
161+
}
163162
s.MessageFactory = s.protoMessageFactory
164163
s.ProtoRegistry = new(protoregistry.Types)
165164
return nil

0 commit comments

Comments
 (0)