Skip to content

Commit 76f8ebb

Browse files
committed
Do not wrap resource __repr__ output in <> to render tracebacks properly in browser.
1 parent e2fc192 commit 76f8ebb

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

CHANGES.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ Changelog
44
1.3 (unreleased)
55
----------------
66

7-
- Nothing changed yet.
7+
- Do not wrap resource ``__repr__`` output in ``<>`` to render tracebacks
8+
properly in browser.
9+
[lenadax]
810

911

1012
1.2 (2022-12-21)

webresource/_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ def _render_tag(self, tag, closing_tag, **attrs):
237237

238238
def __repr__(self):
239239
return (
240-
'<{} name="{}", depends="{}">'
240+
'{} name="{}", depends="{}"'
241241
).format(
242242
self.__class__.__name__,
243243
self.name,
@@ -585,7 +585,7 @@ def _filtered_resources(self, type_, members=None):
585585
return resources
586586

587587
def __repr__(self):
588-
return '<{} name="{}">'.format(
588+
return '{} name="{}"'.format(
589589
self.__class__.__name__,
590590
self.name
591591
)

webresource/tests.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def test_Resource(self, tempdir):
111111
self.assertEqual(resource.type_, None)
112112
self.assertEqual(
113113
repr(resource),
114-
'<Resource name="res", depends="None">'
114+
'Resource name="res", depends="None"'
115115
)
116116

117117
resource = Resource(name='res', resource='res.ext')
@@ -239,7 +239,7 @@ def test_ScriptResource(self, tempdir):
239239
self.assertEqual(script.nomodule, None)
240240
self.assertEqual(
241241
repr(script),
242-
'<ScriptResource name="js_res", depends="None">'
242+
'ScriptResource name="js_res", depends="None"'
243243
)
244244
self.assertEqual(
245245
script.render('https://tld.org'),
@@ -301,7 +301,7 @@ def test_LinkMixin(self):
301301
self.assertEqual(link.title, None)
302302
self.assertEqual(
303303
repr(link),
304-
'<LinkMixin name="link_res", depends="None">'
304+
'LinkMixin name="link_res", depends="None"'
305305
)
306306
link.hreflang = 'en'
307307
link.media = 'screen'
@@ -327,7 +327,7 @@ def test_LinkResource(self):
327327
self.assertIsInstance(link, LinkMixin)
328328
self.assertEqual(
329329
repr(link),
330-
'<LinkResource name="icon_res", depends="None">'
330+
'LinkResource name="icon_res", depends="None"'
331331
)
332332
link.rel = 'icon'
333333
link.type_ = 'image/png'
@@ -355,7 +355,7 @@ def test_StyleResource(self):
355355
self.assertEqual(style.rel, 'stylesheet')
356356
self.assertEqual(
357357
repr(style),
358-
'<StyleResource name="css_res", depends="None">'
358+
'StyleResource name="css_res", depends="None"'
359359
)
360360
self.assertEqual(style.render('https://tld.org'), (
361361
'<link href="https://tld.org/res.css" media="all" '
@@ -377,7 +377,7 @@ def test_ResourceGroup(self):
377377
self.assertIsInstance(group, ResourceMixin)
378378
self.assertEqual(group.name, 'groupname')
379379
self.assertEqual(group.members, [])
380-
self.assertEqual(repr(group), '<ResourceGroup name="groupname">')
380+
self.assertEqual(repr(group), 'ResourceGroup name="groupname"')
381381

382382
res = wr.ScriptResource(name='name', resource='name.js')
383383
group.add(res)
@@ -452,15 +452,15 @@ def test_ResourceCircularDependencyError(self):
452452
err = wr.ResourceCircularDependencyError([resource])
453453
self.assertEqual(str(err), (
454454
'Resources define circular dependencies: '
455-
'[<Resource name="res1", depends="[\'res2\']">]'
455+
'[Resource name="res1", depends="[\'res2\']"]'
456456
))
457457

458458
def test_ResourceMissingDependencyError(self):
459459
resource = Resource(name='res', resource='res.ext', depends='missing')
460460
err = wr.ResourceMissingDependencyError(resource)
461461
self.assertEqual(str(err), (
462462
'Resource defines missing dependency: '
463-
'<Resource name="res", depends="[\'missing\']">'
463+
'Resource name="res", depends="[\'missing\']"'
464464
))
465465

466466
def test_ResourceResolver__flat_resources(self):

0 commit comments

Comments
 (0)