Skip to content

The package doesn't work with Symfony 3.3.0+ #3

@mlocati

Description

@mlocati

This package calls directly Request::setTrustedProxies(), which requires a 2nd parameter since Symfony 3.3.0+.

concretecms/concretecms#6711 fixes the Request::setTrustedProxies() call for the core, so IMHO the package should simply store its data to concrete.security.trusted_proxies.ips and let the core handle it.

If it's ok, I have some code that already implements it, and I can create a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions