Adjusting variable names and adding a new test case for connection alive state

Author: vrslev

packages/stompman/stompman/connection.py

@@ -14,7 +14,7 @@
 
 @dataclass(kw_only=True)
 class AbstractConnection(Protocol):
-    last_read_time_ms: float | None = field(init=False, default=None)
+    last_read_time: float | None = field(init=False, default=None)
 
     @classmethod
     async def connect(
@@ -103,7 +103,7 @@ async def read_frames(self) -> AsyncGenerator[AnyServerFrame, None]:
                 raw_frames = await asyncio.wait_for(
                     self._read_non_empty_bytes(self.read_max_chunk_size), timeout=self.read_timeout
                 )
-            self.last_read_time_ms = time.time()
+            self.last_read_time = time.time()
 
             for frame in cast("Iterator[AnyServerFrame]", parser.parse_frames_from_chunk(raw_frames)):
                 yield frame

packages/stompman/stompman/connection_manager.py

@@ -29,9 +29,9 @@ class ActiveConnectionState:
     server_heartbeat: Heartbeat
 
     def is_alive(self) -> bool:
-        if not (last_read_time_ms := self.connection.last_read_time_ms):
+        if not (last_read_time := self.connection.last_read_time):
             return True
-        return (self.server_heartbeat.will_send_interval_ms / 1000) > (time.time() - last_read_time_ms)
+        return (self.server_heartbeat.will_send_interval_ms / 1000) > (time.time() - last_read_time)
 
 
 @dataclass(kw_only=True, slots=True)

packages/stompman/test_stompman/test_connection_manager.py

@@ -1,4 +1,5 @@
 import asyncio
+import time
 from collections.abc import AsyncGenerator, AsyncIterable
 from ssl import SSLContext
 from typing import Literal, Self
@@ -7,6 +8,7 @@
 import pytest
 from stompman import (
     AnyServerFrame,
+    Client,
     ConnectedFrame,
     ConnectFrame,
     ConnectionLostError,
@@ -16,11 +18,17 @@
     FailedAllWriteAttemptsError,
     Heartbeat,
     MessageFrame,
+    ReceiptFrame,
 )
 from stompman.connection_lifespan import EstablishedConnectionResult
 from stompman.connection_manager import ActiveConnectionState
 
-from test_stompman.conftest import BaseMockConnection, EnrichedConnectionManager, build_dataclass
+from test_stompman.conftest import (
+    BaseMockConnection,
+    EnrichedConnectionManager,
+    build_dataclass,
+    create_spying_connection,
+)
 
 pytestmark = [pytest.mark.anyio, pytest.mark.usefixtures("mock_sleep")]
 
@@ -347,3 +355,16 @@ class MockConnection(BaseMockConnection):
 async def test_maybe_write_frame_ok() -> None:
     async with EnrichedConnectionManager(connection_class=BaseMockConnection) as manager:
         assert await manager.maybe_write_frame(build_dataclass(ConnectFrame))
+
+
+@pytest.mark.parametrize("is_alive", [True, False])
+async def test_connection_alive(is_alive: bool) -> None:  # noqa: FBT001
+    connection_class, _ = create_spying_connection(
+        [ConnectedFrame(headers={"version": Client.PROTOCOL_VERSION, "heart-beat": "1000,1000"})],
+        [],
+        [build_dataclass(ReceiptFrame)],
+    )
+    connection_manager = await EnrichedConnectionManager(connection_class=connection_class).__aenter__()
+    assert connection_manager._active_connection_state
+    connection_manager._active_connection_state.connection.last_read_time = time.time() - 1 + is_alive
+    assert connection_manager._active_connection_state.is_alive() == is_alive