Remove stompman.Client(on_unhandled_message_frame=) (#49)

Author: vrslev

README.md

@@ -27,7 +27,6 @@ async with stompman.Client(
 
     # Handlers:
     on_error_frame=lambda error_frame: print(error_frame.body),
-    on_unhandled_message_frame=lambda message_frame: print(message_frame.body),
     on_heartbeat=lambda: print("Server sent a heartbeat"),
 
     # Optional parameters with sensible defaults:

stompman/client.py

@@ -212,7 +212,6 @@ class Client:
 
     servers: list[ConnectionParameters] = field(kw_only=False)
     on_error_frame: Callable[[ErrorFrame], None] | None = None
-    on_unhandled_message_frame: Callable[[MessageFrame], None] | None = None
     on_heartbeat: Callable[[], None] | None = None
 
     heartbeat: Heartbeat = field(default=Heartbeat(1000, 1000))
@@ -296,8 +295,6 @@ async def _listen_to_frames(self) -> None:
                     case MessageFrame():
                         if subscription := self._active_subscriptions.get(frame.headers["subscription"]):
                             task_group.create_task(subscription._run_handler(frame=frame))  # noqa: SLF001
-                        elif self.on_unhandled_message_frame:
-                            self.on_unhandled_message_frame(frame)
                     case ErrorFrame():
                         if self.on_error_frame:
                             self.on_error_frame(frame)

tests/test_client.py

@@ -322,7 +322,7 @@ async def test_client_listen_routing_ok(monkeypatch: pytest.MonkeyPatch) -> None
                 build_dataclass(ReceiptFrame),
                 (first_message_frame := build_dataclass(MessageFrame, headers={"subscription": first_sub_id})),
                 (error_frame := build_dataclass(ErrorFrame)),
-                (second_message_frame := build_dataclass(MessageFrame)),
+                (_second_message_frame := build_dataclass(MessageFrame)),
                 (third_message_frame := build_dataclass(MessageFrame, headers={"subscription": second_sub_id})),
                 HeartbeatFrame(),
             ]
@@ -335,7 +335,6 @@ async def test_client_listen_routing_ok(monkeypatch: pytest.MonkeyPatch) -> None
         connection_class=connection_class,
         on_error_frame=(on_error_frame := mock.Mock()),
         on_heartbeat=(on_heartbeat := mock.Mock()),
-        on_unhandled_message_frame=(on_unhandled_message_frame := mock.Mock()),
     ) as client:
         first_subscription = await client.subscribe(
             FAKER.pystr(), handler=first_message_handler, on_suppressed_exception=first_error_handler
@@ -356,7 +355,6 @@ async def test_client_listen_routing_ok(monkeypatch: pytest.MonkeyPatch) -> None
 
     on_error_frame.assert_called_once_with(error_frame)
     on_heartbeat.assert_called_once_with()
-    on_unhandled_message_frame.assert_called_once_with(second_message_frame)
 
 
 @pytest.mark.parametrize("side_effect", [None, SomeError])