diff --git a/auto_typing_final/transform.py b/auto_typing_final/transform.py index 3a3f144..b348957 100644 --- a/auto_typing_final/transform.py +++ b/auto_typing_final/transform.py @@ -92,7 +92,7 @@ def _make_definition_from_definition_node(node: SgNode) -> Definition: def _should_skip_global_variable(definition: Definition) -> bool: return isinstance(definition, EditableAssignmentWithoutAnnotation | EditableAssignmentWithAnnotation) and ( - not (definition.left.isupper() and len(definition.left) > 1) + not ((definition.left.isupper() or definition.left.islower()) and len(definition.left) > 1) or any(one_pattern in definition.right for one_pattern in IGNORED_DEFINITION_PATTERNS) ) diff --git a/docs/global_vars_enabled.md b/docs/global_vars_enabled.md index ded63c7..40a50c2 100644 --- a/docs/global_vars_enabled.md +++ b/docs/global_vars_enabled.md @@ -14,7 +14,7 @@ DEBUG = True # insert ### Global vs. Local Variable Scope ```python MY_CONSTANT = 42 # insert -global_var = "hello" +global_var = "hello" # insert def foo(): local_var = 1 # insert @@ -48,12 +48,12 @@ FRUIT = Apple | Banana # insert ### Code Examples with Header Improvements -### Unchanged Global Assignment +### Changed lower case assignment ```python -global_var = 42 +global_var = 42 # insert ``` -### Simple Assignment +### Not lower case assignment ```python myVar = "hello" ``` diff --git a/tests/test_transform_imports.py b/tests/test_transform_imports.py index d1f0716..7fd118c 100644 --- a/tests/test_transform_imports.py +++ b/tests/test_transform_imports.py @@ -79,17 +79,6 @@ def f(): def f(): a = 1 a = 2 -""", - """ -typing = 1 - -def f(): - a = 1 ---- -typing = 1 - -def f(): - a: typing.Final = 1 """, ], )