Skip to content

parse_list_marker Does Not Correctly Check for CRLF. #550

@joegm

Description

@joegm

I'm just reading through the code, and I may be wrong but...

      /* blocks.c > parse_list_marker */

      // require non-blank content after list marker:
      while (S_is_space_or_tab(peek_at(input, i))) {
        i++;
      }
      if (peek_at(input, i) == '\n') {
        return 0;
      }

Seeing as the rest of the parser tries to be compatible with CRLF, I would expect S_is_line_end_char to be used instead of just comparing to a newline char. Am I missing why this is not necessary?

Edit: In the following branch for numbered markers, there is the same logic but S_is_line_end_char is used instead, so I'm pretty sure now that this is an oversight.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions