Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Commit 6ad9ac5

Browse files
Refactor towards more idiomatic async code
This refactoring addresses several pain points of the current codebase: 1. We used to write to the env file from several places. This made it hard to understand, what was actually written to the file. It was also error prone because there were several concurrent tasks doing it. 2. Many APIs were stringly-typed. This made it hard to understand, what information is actually passed around. 3. The codebase was still using old Futures in many places. Using new futures allows us to use async/await which makes the code a lot shorter.
1 parent 6fd788b commit 6ad9ac5

File tree

14 files changed

+672
-917
lines changed

14 files changed

+672
-917
lines changed

Cargo.lock

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ edition = "2018"
66

77
[dependencies]
88
anyhow = "1.0.25"
9+
derive_more = "0.99.2"
910
dirs = "2"
1011
emerald-vault-core = { git = "http://github.com/thomaseizinger/emerald-vault.git", branch = "create-comit-app-compatible", default-features = false }
1112
envfile = "0.2"

src/cnd_settings.rs

Lines changed: 0 additions & 127 deletions
This file was deleted.

0 commit comments

Comments
 (0)